Commit Graph

239 Commits

Author SHA1 Message Date
Itay Grudev
bdbb09b5f2
v3.3.0 2021-06-02 10:57:30 +03:00
Itay Grudev
c557da5d0c
Merge pull request #133 from njeisecke/master
Fix protocol to solve #121 and #125
2021-06-01 23:59:59 +03:00
Nils Jeisecke
25a7b60982 Ensure data sent via SingleApplication::sendMessage is received completely
Whilst the initial "connect" message is framed with a length header,
this was missing for the user data.

Thus there was no guarantee that the message frame was really received
completely on emitting the "receivedMessage" signal.

This change splits the previous "StageConnected" state into
"StageConnectedHeader" and "StageConnectedBody" and does some
refactoring to allow using the same write and read functions as the
"init" messages.
2021-06-01 04:10:53 +02:00
Nils Jeisecke
0c458ec8c9 Add simple acknowledge protocol to ensure the server has received all data
The server now acknowledges every received message by sending a \r.

By waiting for the acknowledgement, clients should no longer terminate
too early, causing bytes getting lost in Qt's internal socket handling.

Message handling in the server is simplified because we can now rely
on the readyRead signal being raised for every frame.

This should finally solve #125 and #121.

What remains is to correctly handle data sent using
SingleApplication::sendMessage.
2021-05-31 16:12:32 +02:00
Itay Grudev
fda9c4b178
Merge pull request #132 from itay-grudev/removed_incorrect_coment_in_basic_example
Removed incorrect comment in the basic example
2021-04-29 03:26:24 +03:00
Itay Grudev
7e494b5d5e
Removed incorreced comment in the basic example
Fixes #131
2021-04-28 12:06:37 +03:00
Shatur95
c2fd401540 Simplify randomSleep() for old Qt version 2021-04-12 14:17:53 +03:00
Itay Grudev
9f65e9c7fe
Merge pull request #129 from jonaski/signalslots
Fix signal-slot issues
2021-03-26 09:59:27 +02:00
Jonas Kvinge
4052d37110 Fix signal-slot issues 2021-03-26 00:16:25 +01:00
Shatur95
4aeac8fa3e Mark getters as const 2021-01-25 01:36:36 +02:00
Itay Grudev
e99b8df38f
Merge pull request #125 from dail8859/fix-123
Remove ConnectionInfo after socket is destroyed
2020-12-25 08:56:18 +00:00
dail8859
5e7b302776
Update singleapplication_p.cpp
Co-authored-by: Hennadii Chernyshchyk <genaloner@gmail.com>
2020-12-23 15:42:56 -05:00
dail8859
99cd51d5a2 Remove ConnectionInfo after socket is destroyed
This leaves the ConnectionInfo in a valid state, even after the socket is disconnected, which could still have a readyRead() signal emitted.

Closes #123
2020-12-22 21:03:10 -05:00
Itay Grudev
451a42d8f9
Merge pull request #124 from Shatur95/use-const-reference
Use const reference and bump GitHub actions
2020-12-21 19:23:04 +02:00
Shatur95
963d42ceb6 Set Ubuntu version explicitly 2020-12-21 19:13:33 +02:00
Shatur95
0aabf7705a Bump GitHub actions 2020-12-21 19:09:21 +02:00
Shatur95
7bdb497a83 Pass usedData by const reference 2020-12-21 19:07:36 +02:00
Itay Grudev
dc8042b5db
Merge pull request #122 from LorenDB/master
Allow adding unique userdata to instances
2020-12-17 11:47:01 +02:00
Loren Burkholder
f236032cf9 Allow adding unique userdata to instances 2020-12-16 22:17:24 -05:00
Itay Grudev
aede311d28
Update CHANGELOG.md 2020-11-23 12:03:51 +00:00
Jonas Kvinge
3dd0c6dfbd
Merge pull request #120 from Shatur95/master
Add Qt6 CI builds
2020-10-27 20:26:05 +01:00
Shatur95
ab58a29cab Enable checks for warnings 2020-10-24 14:31:53 +03:00
Shatur95
6c97f3e80d Add Qt6 configuration 2020-10-24 14:20:37 +03:00
Itay Grudev
c6227ee2cd
Merge pull request #118 from Shatur95/improve-qt6-support
Use QT_DEFAULT_MAJOR_VERSION
2020-10-21 20:27:27 +01:00
Shatur95
dccc37e9d4 Use QT_DEFAULT_MAJOR_VERSION 2020-10-21 20:48:51 +03:00
Itay Grudev
7983644b83
Update README.md 2020-10-19 13:50:54 +01:00
Itay Grudev
2f44044c32
v3.2.0 Changelog 2020-10-18 10:42:09 +01:00
Itay Grudev
b835987b59
Update build-cmake.yml
Disabled Qt 6 build specs temporarily
2020-10-18 10:33:30 +01:00
Itay Grudev
cd18cd378f
Added Qt 6.0 to the build tests 2020-10-18 09:47:17 +01:00
Itay Grudev
a627bc24fa
Merge pull request #114 from Shatur95/fix-clang-tidy-warnings
Fix Clang Tidy warnings
2020-10-18 09:44:21 +01:00
Itay Grudev
ba6388d47c
Merge pull request #116 from jonaski/qt6-cmake
Update CMake to support Qt 6
2020-10-18 09:44:07 +01:00
Itay Grudev
ad9c7a6d32
Merge pull request #117 from jonaski/qt6-checksum
Fix use of qChecksum with Qt 6
2020-10-18 09:43:50 +01:00
Jonas Kvinge
82f28549e6 Update CMake to support Qt 6 2020-10-18 01:02:09 +02:00
Jonas Kvinge
b5e6e2ba75 Fix use of qChecksum with Qt 6 2020-10-18 00:58:52 +02:00
Shatur95
f3de0114f4 Remove extra Q_D
No longer needed as getUsername() is now static.
2020-10-15 23:16:21 +03:00
Shatur95
199defc4dd Remove unused marco
No longer needed since applicationPid() now is static.
2020-10-15 23:06:50 +03:00
Shatur95
e17c715faf Fix Clang Tidy warnings
readability-convert-member-functions-to-static
readability-static-accessed-through-instance
readability-make-member-function-const
readability-inconsistent-declaration-parameter-name
2020-10-15 21:41:00 +03:00
Itay Grudev
5d837262f4
Merge pull request #113 from Shatur95/fix-conversion-warning
Fix conversion from int to quint32
2020-10-15 09:22:43 +01:00
Shatur95
3d30f4f776 Update install-qt-action 2020-10-15 01:56:14 +03:00
Shatur95
a8fb6b49f5 Fix implicit conversion 2020-10-15 01:29:25 +03:00
Shatur95
fae8a8a65f Fix conversion from int to quint32 2020-10-10 20:31:47 +03:00
Itay Grudev
0e42d86cec
Merge pull request #112 from iakov/patch-1
Fix build issue with MinGW GCC pedantic mode
2020-10-06 16:20:38 +01:00
iakov
800bb858a8
Fix build issue with MinGW GCC pedantic mode
Without guard this define from 3230430311 (diff-35c7c4188004bde084344a3aa8eeab6dR60) introduced compilation warning/error, and can break compilation
2020-10-06 13:56:20 +03:00
Itay Grudev
224f1d1734
Merge pull request #111 from jonaski/connecttoprimary
Fix return value of connectToPrimary() when connect is successful
2020-10-06 10:16:09 +01:00
Jonas Kvinge
a121f61ca1 Fix return value of connectToPrimary() when connect is successful 2020-10-05 22:13:03 +02:00
Itay Grudev
26ed3486f9
Merge pull request #110 from Kolcha/qt59-msvc
fixed build with Qt 5.9 MSVC2017
2020-10-04 02:01:38 +01:00
Nick Korotysh
3230430311
fixed build with Qt 5.9 MSVC2017
define NOMINMAX before <Windows.h> inclusion to disable min/max macros
defined in it. these macros conflict with any min/max functions and it
is common practice to disable them adding NOMINMAX define.
2020-10-02 14:17:34 +03:00
Itay Grudev
9a408690ce Fixed typo in the CHANGELOG 2020-09-09 02:50:55 +01:00
Itay Grudev
0a7c90e0a6 v3.1.5 2020-09-09 02:34:16 +01:00
Itay Grudev
ca8e9aaa9e Removed debugging information for the instanceStarted signal 2020-09-09 02:30:43 +01:00