Gabi Melman
685ad74d53
Merge pull request #1288 from yipdw/bugfix/use-64-bit-file-access
...
Use _FILE_OFFSET_BITS=64 when building on Linux 32-bit systems
2019-10-28 20:48:56 +02:00
David Yip
288ea11534
Use _FILE_OFFSET_BITS=64 when building tests on Linux 32-bit systems
...
When cross-compiling spdlog from x86-64 to armhf, I ran spdlog-utests
via qemu-arm and noticed that the "daily_logger rotate" test was failing
because count_files always returned zero.
Investigation of count_files revealed that readdir was returning nullptr
immediately and setting errno to 75, i.e. "value too large for defined
data type". I suspected this had something to do with some 64 vs.
32-bit thing, so I added _FILE_OFFSET_BITS=64 to the build and that
seems to have made readdir happy.
It might be safe to add _FILE_OFFSET_BITS=64 for all Linux builds, but
it only seems to be necessary for the 32-bit case (which is a pretty
small audience these days -- I'm only building for armhf to target a
Raspberry Pi 3 running Raspbian, which runs in 32-bit mode).
2019-10-28 13:23:01 -05:00
Gabi Melman
b848ff8db9
Merge pull request #1285 from masmullin2000/v1.x
...
Remove unused variable
2019-10-25 22:22:59 +03:00
Michael Mullin
5881fcb0d6
Remove unused variable
2019-10-25 14:47:38 -04:00
Gabi Melman
491a2e8732
Update os-inl.h
2019-10-25 18:59:02 +03:00
gabime
4a620a2c5e
Merge branch 'Issue-1248' into v1.x
2019-10-25 16:56:26 +03:00
gabime
05105155f8
refactoed file_helper
2019-10-25 16:55:24 +03:00
gabime
9f96545fa7
refactoed file_helper
2019-10-25 16:52:12 +03:00
gabime
0c60107e62
refactoed file_helper
2019-10-25 16:50:06 +03:00
gabime
49eb9cbdd8
Removed junk folder
2019-10-25 16:26:21 +03:00
gabime
594d226056
update tests
2019-10-25 16:20:24 +03:00
gabime
aac7dccf45
comment
2019-10-25 16:17:55 +03:00
gabime
c19e325b83
Added some tests for create_dir
2019-10-25 16:17:02 +03:00
gabime
bd92c23add
comment
2019-10-25 16:07:10 +03:00
gabime
88335bd92e
clang-format
2019-10-25 16:05:12 +03:00
gabime
a4602021d8
Renamed private members of file_helper
2019-10-25 16:04:07 +03:00
gabime
dbe5c17a96
Renamed file_exists()->path_exists()
2019-10-25 15:56:23 +03:00
gabime
c40555c0ac
clang-format
2019-10-25 15:44:53 +03:00
gabime
bfc76278a9
update tests
2019-10-25 15:24:54 +03:00
gabime
a1f283946e
updated os::dir_name and tests
2019-10-25 14:29:57 +03:00
gabime
066087b383
Update create_dir
2019-10-25 14:14:50 +03:00
gabime
e9d42e059f
// support forward slash in windows
2019-10-25 12:52:39 +03:00
Gabi Melman
d1dadc9814
Merge pull request #1283 from bencsikandrei/refactor/cmake-minor-duplication-removal
...
Minor cmake code duplication improvement
2019-10-25 12:28:10 +03:00
Andrei-Florin BENCSIK
2cc620ef33
Function instead of macro
...
Be more consistent with the existing code and with the naming
_function -> function
2019-10-25 11:15:07 +03:00
Andrei-Florin BENCSIK
cee705ccd3
Minor cmake code duplication improvement
...
Create a macro to add tests for both static/header only.
The only differneces between these two are the libraries they link
with and the target names. Created the simple macro:
_spdlog_prepare_test(<target> <spdlog_lib>)
which does the work.
Signed-off-by: Andrei-Florin BENCSIK <andrei.bencsik@gmail.com>
2019-10-24 22:57:47 +03:00
gabime
a8f72424db
Merge branch 'Issue-1248' of https://github.com/gabime/spdlog into Issue-1248
2019-10-21 13:43:57 +03:00
gabime
31ed133932
Added dir_name tests
2019-10-21 13:42:25 +03:00
Gabi Melman
d3c6974e99
Update os.h
2019-10-20 19:09:37 +03:00
Gabi Melman
1271081865
Update os-inl.h
2019-10-20 19:08:47 +03:00
Gabi Melman
8a638a95a0
Update os-inl.h
2019-10-20 18:31:04 +03:00
Gabi Melman
d9f726f2a5
Add global namespace qualifiers to global function calls in os-inl.h
2019-10-20 18:25:09 +03:00
Gabi Melman
5f3521b3d4
Update utils.cpp
2019-10-20 17:55:13 +03:00
gabime
9a68bd8cc8
Fixed missing include
2019-10-20 17:48:13 +03:00
gabime
9b7812a0f2
auto create log dir
2019-10-20 17:40:56 +03:00
gabime
4858d7e454
Fix #1274
2019-10-20 10:27:17 +03:00
gabime
fbb3f41dff
Fix #1273
2019-10-20 10:22:44 +03:00
Gabi Melman
1472048b97
Merge pull request #1275 from flopp/spelling
...
Fix some spelling errors.
2019-10-19 11:09:11 +03:00
Florian Pigorsch
4aad51a352
Fix some spelling errors.
...
casese -> cases (1)
chache -> cache (1)
cirucal -> circular (1)
dependecy -> dependency (1)
detrmine -> determine (2)
eavluate -> evaluate (1)
exertnal -> external (1)
ony -> only (1)
registation -> registration (3)
registring -> registering (2)
regsistration -> registration (3)
seperate -> separate (2)
wit -> with (1)
withe -> with (1)
2019-10-19 09:42:38 +02:00
gabime
9a0a0c2d8c
clang-format
2019-10-18 16:14:08 +03:00
gabime
fcc809f4f1
Refactored logger
2019-10-18 16:10:57 +03:00
Gabi Melman
f3369677ef
Merge pull request #1270 from jktjkt/fix-clang7-libc++
...
Fix build failure on clang 7 with libc++
2019-10-18 11:38:56 +03:00
Jan Kundrát
a03f9eb156
Fix build failure on clang 7 with libc++
...
Unlike the GNU C++ STL, there's no implicit include for <array> in this
one, apparently.
2019-10-18 10:14:44 +02:00
Gabi Melman
aa65dd8905
version 1.4.3 rc
2019-10-11 19:48:33 +03:00
Gabi Melman
856b4f4654
Update README.md
2019-10-09 23:22:45 +03:00
gabime
9369fe8c27
Fix #1262
2019-10-09 21:41:02 +03:00
gabime
1549ff12f1
Replace STRING(PREPEND ..) in CMakeLists.txt to support older CMake versions
2019-10-06 13:13:26 +03:00
gabime
70357ceff2
clang-format
2019-10-06 00:31:38 +03:00
gabime
cfe7cac1c4
version 1.4.2
2019-10-06 00:30:40 +03:00
gabime
fb70eca0a3
CmakeLists.txt: add -pthread to pkg-config
2019-10-04 21:56:17 +03:00
gabime
cf2bf488a2
CmakeLists.txt: Fixed package config generation
2019-10-04 21:49:20 +03:00
