From bf40855825383a96bfa60f4594f29b4c36acf9cc Mon Sep 17 00:00:00 2001 From: gabime Date: Sun, 3 Nov 2019 17:04:34 +0200 Subject: [PATCH] Micro-optimize level checking by inlining --- include/spdlog/logger-inl.h | 10 ---------- include/spdlog/logger.h | 10 ++++++++-- 2 files changed, 8 insertions(+), 12 deletions(-) diff --git a/include/spdlog/logger-inl.h b/include/spdlog/logger-inl.h index 021aae9d..bc8232d8 100644 --- a/include/spdlog/logger-inl.h +++ b/include/spdlog/logger-inl.h @@ -64,16 +64,6 @@ SPDLOG_INLINE void swap(logger &a, logger &b) a.swap(b); } -SPDLOG_INLINE bool logger::should_log(level::level_enum msg_level) const -{ - return msg_level >= level_.load(std::memory_order_relaxed); -} - -SPDLOG_INLINE bool logger::should_backtrace() const -{ - return tracer_.enabled(); -} - SPDLOG_INLINE void logger::set_level(level::level_enum log_level) { level_.store(log_level); diff --git a/include/spdlog/logger.h b/include/spdlog/logger.h index 314e5c42..0e182875 100644 --- a/include/spdlog/logger.h +++ b/include/spdlog/logger.h @@ -299,10 +299,16 @@ public: #endif // SPDLOG_WCHAR_TO_UTF8_SUPPORT // return true logging is enabled for the given level. - bool should_log(level::level_enum msg_level) const; + bool should_log(level::level_enum msg_level) const + { + return msg_level >= level_.load(std::memory_order_relaxed); + } // return true if backtrace logging is enabled. - bool should_backtrace() const; + bool should_backtrace() const + { + return tracer_.enabled(); + } void set_level(level::level_enum log_level);