From a3a0c9d66386962fcaf0178fcae03ac77c1e0257 Mon Sep 17 00:00:00 2001 From: Eugene Smirnov Date: Tue, 27 Aug 2024 03:04:04 +0200 Subject: [PATCH] compilation error gcc 8.5 with [-Werror=suggest-override] (#3158) --- include/spdlog/sinks/ansicolor_sink.h | 2 +- include/spdlog/sinks/base_sink.h | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/include/spdlog/sinks/ansicolor_sink.h b/include/spdlog/sinks/ansicolor_sink.h index ff53730c..d0dadd75 100644 --- a/include/spdlog/sinks/ansicolor_sink.h +++ b/include/spdlog/sinks/ansicolor_sink.h @@ -40,7 +40,7 @@ public: void log(const details::log_msg &msg) override; void flush() override; - void set_pattern(const std::string &pattern) final; + void set_pattern(const std::string &pattern) final override; void set_formatter(std::unique_ptr sink_formatter) override; // Formatting codes diff --git a/include/spdlog/sinks/base_sink.h b/include/spdlog/sinks/base_sink.h index 1ca772a6..1b4bb068 100644 --- a/include/spdlog/sinks/base_sink.h +++ b/include/spdlog/sinks/base_sink.h @@ -28,10 +28,10 @@ public: base_sink &operator=(const base_sink &) = delete; base_sink &operator=(base_sink &&) = delete; - void log(const details::log_msg &msg) final; - void flush() final; - void set_pattern(const std::string &pattern) final; - void set_formatter(std::unique_ptr sink_formatter) final; + void log(const details::log_msg &msg) final override; + void flush() final override; + void set_pattern(const std::string &pattern) final override; + void set_formatter(std::unique_ptr sink_formatter) final override; protected: // sink formatter