diff --git a/include/spdlog/sinks/win_eventlog_sink.h b/include/spdlog/sinks/win_eventlog_sink.h index b594e0c9..1adbddc3 100644 --- a/include/spdlog/sinks/win_eventlog_sink.h +++ b/include/spdlog/sinks/win_eventlog_sink.h @@ -194,23 +194,23 @@ template class win_eventlog_sink : public base_sink { private: - HANDLE hEventLog_{NULL}; + HANDLE h_eventlog_{NULL}; internal::sid_t current_user_sid_; std::string source_; WORD event_id_; HANDLE event_log_handle() { - if (!hEventLog_) + if (!h_eventlog_) { - hEventLog_ = ::RegisterEventSource(nullptr, source_.c_str()); - if (!hEventLog_ || hEventLog_ == (HANDLE)ERROR_ACCESS_DENIED) + h_eventlog_ = ::RegisterEventSource(nullptr, source_.c_str()); + if (!h_eventlog_ || h_eventlog_ == (HANDLE)ERROR_ACCESS_DENIED) { SPDLOG_THROW(internal::win32_error("RegisterEventSource")); } } - return hEventLog_; + return h_eventlog_; } protected: @@ -241,7 +241,7 @@ public: { try { - current_user_sid_ = internal::sid_t::get_current_user_sid(); + current_user_sid_ = internal::sid_t::sid_t(); } catch (...) { @@ -250,10 +250,11 @@ public: } } - ~win_eventlog_sink() + ~win_eventlog_sink() override { - if (hEventLog_) - DeregisterEventSource(hEventLog_); + if (h_eventlog_) { + DeregisterEventSource(h_eventlog_); + } } };