create MSVC_OPTIONS list only if compiler is msvc

This commit is contained in:
Trond H Emaus 2020-03-28 10:26:32 +01:00
parent 7054cf7a35
commit 3e4df86ac0

View File

@ -28,10 +28,13 @@ endfunction()
# Turn on warnings on the given target # Turn on warnings on the given target
function(spdlog_enable_warnings target_name) function(spdlog_enable_warnings target_name)
list(APPEND MSVC_OPTIONS "/W3") if (CMAKE_CXX_COMPILER_ID STREQUAL "MSVC")
if(MSVC_VERSION GREATER 1900) #Allow non fatal security wanrnings for msvc 2015 list(APPEND MSVC_OPTIONS "/W3")
list(APPEND MSVC_OPTIONS "/WX") if(MSVC_VERSION GREATER 1900) #Allow non fatal security wanrnings for msvc 2015
list(APPEND MSVC_OPTIONS "/WX")
endif()
endif() endif()
target_compile_options(${target_name} PRIVATE target_compile_options(${target_name} PRIVATE
$<$<OR:$<CXX_COMPILER_ID:Clang>,$<CXX_COMPILER_ID:AppleClang>,$<CXX_COMPILER_ID:GNU>>: $<$<OR:$<CXX_COMPILER_ID:Clang>,$<CXX_COMPILER_ID:AppleClang>,$<CXX_COMPILER_ID:GNU>>:
-Wall -Wextra -Wconversion -pedantic -Wfatal-errors> -Wall -Wextra -Wconversion -pedantic -Wfatal-errors>