Refactoring. Rid of open_file for clarity

This commit is contained in:
slapenko 2018-08-02 07:27:49 -05:00
parent 64521005ab
commit 34ada56f5d

View File

@ -55,7 +55,7 @@ public:
throw spdlog_ex("daily_file_sink: Invalid rotation time in ctor"); throw spdlog_ex("daily_file_sink: Invalid rotation time in ctor");
} }
auto now = log_clock::now(); auto now = log_clock::now();
open_file(now); file_helper_.open(FileNameCalc::calc_filename(base_filename_, now_tm(now)), truncate_);
rotation_tp_ = next_rotation_tp_(); rotation_tp_ = next_rotation_tp_();
} }
@ -65,7 +65,7 @@ protected:
if (msg.time >= rotation_tp_) if (msg.time >= rotation_tp_)
{ {
open_file(msg.time); file_helper_.open(FileNameCalc::calc_filename(base_filename_, now_tm(msg.time)), truncate_);
rotation_tp_ = next_rotation_tp_(); rotation_tp_ = next_rotation_tp_();
} }
fmt::memory_buffer formatted; fmt::memory_buffer formatted;
@ -79,11 +79,6 @@ protected:
} }
private: private:
void open_file(log_clock::time_point tp)
{
file_helper_.open(FileNameCalc::calc_filename(base_filename_, now_tm(tp)), truncate_);
}
tm now_tm(log_clock::time_point tp) tm now_tm(log_clock::time_point tp)
{ {
time_t tnow = log_clock::to_time_t(tp); time_t tnow = log_clock::to_time_t(tp);