mirrors/spdlog
1
0
Fork 0
mirror of https://github.com/gabime/spdlog.git synced 2025-01-24 22:49:05 +08:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

Improve rotating sink error handling

Browse Source
This commit is contained in:
gabime 2018-09-18 00:09:58 +03:00
parent 3771d12992
commit 2fa7410c0e
1 changed files with 150 additions and 144 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
include/spdlog/sinks/rotating_file_sink.h
View File

@ -86,24 +86,21 @@ private:
for (auto i = max_files_; i > 0; --i) for (auto i = max_files_; i > 0; --i)
{ {
filename_t src = calc_filename(base_filename_, i - 1); filename_t src = calc_filename(base_filename_, i - 1);
if (!details::file_helper::file_exists(src))
{
continue;
}
filename_t target = calc_filename(base_filename_, i); filename_t target = calc_filename(base_filename_, i);
if (details::file_helper::file_exists(target)) if (!rename_file(src, target))
{ {
if (details::os::remove(target) != 0) // if failed try again after a small delay.
{
throw spdlog_ex("rotating_file_sink: failed removing " + filename_to_str(target), errno);
}
}
if (details::file_helper::file_exists(src) && details::os::rename(src, target) != 0)
{
// if failed try again after small delay.
// this is a workaround to a windows issue, where very high rotation // this is a workaround to a windows issue, where very high rotation
// rates sometimes fail (because of antivirus?). // rates can cause the rename to fail with permission denied (because of antivirus?).
details::os::sleep_for_millis(20); details::os::sleep_for_millis(100);
details::os::remove(target); if (!rename_file(src, target))
if (details::os::rename(src, target) != 0)
{ {
file_helper_.reopen(true); // truncate the log file anyway to prevent it to grow beyond its limit!
throw spdlog_ex( throw spdlog_ex(
"rotating_file_sink: failed renaming " + filename_to_str(src) + " to " + filename_to_str(target), errno); "rotating_file_sink: failed renaming " + filename_to_str(src) + " to " + filename_to_str(target), errno);
} }
@ -112,6 +109,15 @@ private:
file_helper_.reopen(true); file_helper_.reopen(true);
} }
// delete the target if exists, and rename the src file to target
// return true on success, false otherwise.
bool rename_file(const filename_t &src_filename, const filename_t &target_filename)
{
// try to delete the target file in case it already exists.
(void)details::os::remove(target_filename);
return details::os::rename(src_filename, target_filename) == 0;
}
filename_t base_filename_; filename_t base_filename_;
std::size_t max_size_; std::size_t max_size_;
std::size_t max_files_; std::size_t max_files_;