Fixed bug #81 (Doesn't compile on OS X under gcc-4.9 )

include/spdlog/details/format.cc

@@ -1,7 +1,7 @@
 /*
  Formatting library for C++
 
-Copyright (c) 2012 - 2014, Victor Zverovich
+ Copyright (c) 2012 - 2015, Victor Zverovich
  All rights reserved.
 
  Redistribution and use in source and binary forms, with or without
@@ -66,10 +66,8 @@ using fmt::internal::Arg;
 #ifndef FMT_THROW
 # if FMT_EXCEPTIONS
 #  define FMT_THROW(x) throw x
-#  define FMT_RETURN_AFTER_THROW(x)
 # else
 #  define FMT_THROW(x) assert(false)
-#  define FMT_RETURN_AFTER_THROW(x) return x
 # endif
 #endif
 
@@ -83,8 +81,20 @@ using fmt::internal::Arg;
 # pragma warning(push)
 # pragma warning(disable: 4127)  // conditional expression is constant
 # pragma warning(disable: 4702)  // unreachable code
+// Disable deprecation warning for strerror. The latter is not called but
+// MSVC fails to detect it.
+# pragma warning(disable: 4996)
 #endif
 
+// Dummy implementations of strerror_r and strerror_s called if corresponding
+// system functions are not available.
+static inline fmt::internal::None<> strerror_r(int, char *, ...) {
+  return fmt::internal::None<>();
+}
+static inline fmt::internal::None<> strerror_s(char *, std::size_t, ...) {
+  return fmt::internal::None<>();
+}
+
 namespace {
 
 #ifndef _MSC_VER
@@ -100,6 +110,12 @@ inline int fmt_snprintf(char *buffer, size_t size, const char *format, ...) {
 # define FMT_SNPRINTF fmt_snprintf
 #endif  // _MSC_VER
 
+#if defined(_WIN32) && defined(__MINGW32__) && !defined(__NO_ISOCEXT)
+# define FMT_SWPRINTF snwprintf
+#else
+# define FMT_SWPRINTF swprintf
+#endif // defined(_WIN32) && defined(__MINGW32__) && !defined(__NO_ISOCEXT)
+
 // Checks if a value fits in int - used to avoid warnings about comparing
 // signed and unsigned integers.
 template <bool IsSigned>
@@ -135,35 +151,57 @@ typedef void(*FormatFunc)(fmt::Writer &, int, fmt::StringRef);
 int safe_strerror(
     int error_code, char *&buffer, std::size_t buffer_size) FMT_NOEXCEPT {
   assert(buffer != 0 && buffer_size != 0);
-    int result = 0;
-#if ((_POSIX_C_SOURCE >= 200112L || _XOPEN_SOURCE >= 600) && !_GNU_SOURCE) || __ANDROID__
-    // XSI-compliant version of strerror_r.
-    result = strerror_r(error_code, buffer, buffer_size);
-    if (result != 0)
-        result = errno;
-#elif _GNU_SOURCE
-    // GNU-specific version of strerror_r.
-    char *message = strerror_r(error_code, buffer, buffer_size);
+
+  class StrError {
+   private:
+    int error_code_;
+    char *&buffer_;
+    std::size_t buffer_size_;
+
+    // A noop assignment operator to avoid bogus warnings.
+    void operator=(const StrError &) {}
+
+    // Handle the result of XSI-compliant version of strerror_r.
+    int handle(int result) {
+      // glibc versions before 2.13 return result in errno.
+      return result == -1 ? errno : result;
+    }
+
+    // Handle the result of GNU-specific version of strerror_r.
+    int handle(char *message) {
       // If the buffer is full then the message is probably truncated.
-    if (message == buffer && strlen(buffer) == buffer_size - 1)
-        result = ERANGE;
-    buffer = message;
-#elif __MINGW32__
+      if (message == buffer_ && strlen(buffer_) == buffer_size_ - 1)
+        return ERANGE;
+      buffer_ = message;
+      return 0;
+    }
+
+    // Handle the case when strerror_r is not available.
+    int handle(fmt::internal::None<>) {
+      return fallback(strerror_s(buffer_, buffer_size_, error_code_));
+    }
+
+    // Fallback to strerror_s when strerror_r is not available.
+    int fallback(int result) {
+      // If the buffer is full then the message is probably truncated.
+      return result == 0 && strlen(buffer_) == buffer_size_ - 1 ?
+            ERANGE : result;
+    }
+
+    // Fallback to strerror if strerror_r and strerror_s are not available.
+    int fallback(fmt::internal::None<>) {
       errno = 0;
-    (void)buffer_size;
-    buffer = strerror(error_code);
-    result = errno;
-#elif _WIN32
-    result = strerror_s(buffer, buffer_size, error_code);
-    // If the buffer is full then the message is probably truncated.
-    if (result == 0 && std::strlen(buffer) == buffer_size - 1)
-        result = ERANGE;
-#else
-    result = strerror_r(error_code, buffer, buffer_size);
-    if (result == -1)
-        result = errno;  // glibc versions before 2.13 return result in errno.
-#endif
-    return result;
+      buffer_ = strerror(error_code_);
+      return errno;
+    }
+
+   public:
+    StrError(int error_code, char *&buffer, std::size_t buffer_size)
+      : error_code_(error_code), buffer_(buffer), buffer_size_(buffer_size) {}
+
+    int run() { return handle(strerror_r(error_code_, buffer_, buffer_size_)); }
+  };
+  return StrError(error_code, buffer, buffer_size).run();
 }
 
 void format_error_code(fmt::Writer &out, int error_code,
@@ -173,14 +211,14 @@ void format_error_code(fmt::Writer &out, int error_code,
   // bad_alloc.
   out.clear();
   static const char SEP[] = ": ";
-    static const char ERR[] = "error ";
+  static const char ERROR_STR[] = "error ";
   fmt::internal::IntTraits<int>::MainType ec_value = error_code;
-    // Subtract 2 to account for terminating null characters in SEP and ERR.
-    std::size_t error_code_size =
-    sizeof(SEP) + sizeof(ERR) + fmt::internal::count_digits(ec_value) - 2;
+  // Subtract 2 to account for terminating null characters in SEP and ERROR_STR.
+  std::size_t error_code_size = sizeof(SEP) + sizeof(ERROR_STR) - 2;
+  error_code_size += fmt::internal::count_digits(ec_value);
   if (message.size() <= fmt::internal::INLINE_BUFFER_SIZE - error_code_size)
     out << message << SEP;
-    out << ERR << error_code;
+  out << ERROR_STR << error_code;
   assert(out.size() <= fmt::internal::INLINE_BUFFER_SIZE);
 }
 
@@ -198,9 +236,7 @@ void report_error(FormatFunc func,
 class IsZeroInt : public fmt::internal::ArgVisitor<IsZeroInt, bool> {
  public:
   template <typename T>
-    bool visit_any_int(T value) {
-        return value == 0;
-    }
+  bool visit_any_int(T value) { return value == 0; }
 };
 
 // Parses an unsigned integer advancing s to the end of the parsed input.
@@ -253,9 +289,8 @@ private:
  public:
   explicit WidthHandler(fmt::FormatSpec &spec) : spec_(spec) {}
 
-    unsigned visit_unhandled_arg() {
+  void report_unhandled_arg() {
     FMT_THROW(fmt::FormatError("width is not integer"));
-        FMT_RETURN_AFTER_THROW(0);
   }
 
   template <typename T>
@@ -275,9 +310,8 @@ public:
 class PrecisionHandler :
     public fmt::internal::ArgVisitor<PrecisionHandler, int> {
  public:
-    unsigned visit_unhandled_arg() {
+  void report_unhandled_arg() {
     FMT_THROW(fmt::FormatError("precision is not integer"));
-        FMT_RETURN_AFTER_THROW(0);
   }
 
   template <typename T>
@@ -310,20 +344,17 @@ public:
       if (is_signed) {
         arg_.type = Arg::INT;
         arg_.int_value = static_cast<int>(static_cast<T>(value));
-            }
-            else {
+      } else {
         arg_.type = Arg::UINT;
         arg_.uint_value = static_cast<unsigned>(
             static_cast<typename fmt::internal::MakeUnsigned<T>::Type>(value));
       }
-        }
-        else {
+    } else {
       if (is_signed) {
         arg_.type = Arg::LONG_LONG;
         arg_.long_long_value =
             static_cast<typename fmt::internal::MakeUnsigned<U>::Type>(value);
-            }
-            else {
+      } else {
         arg_.type = Arg::ULONG_LONG;
         arg_.ulong_long_value =
             static_cast<typename fmt::internal::MakeUnsigned<U>::Type>(value);
@@ -357,15 +388,11 @@ Arg::StringValue<Char> ignore_incompatible_str(Arg::StringValue<wchar_t>);
 
 template <>
 inline Arg::StringValue<char> ignore_incompatible_str(
-    Arg::StringValue<wchar_t>) {
-    return Arg::StringValue<char>();
-}
+    Arg::StringValue<wchar_t>) { return Arg::StringValue<char>(); }
 
 template <>
 inline Arg::StringValue<wchar_t> ignore_incompatible_str(
-    Arg::StringValue<wchar_t> s) {
-    return s;
-}
+    Arg::StringValue<wchar_t> s) { return s; }
 }  // namespace
 
 FMT_FUNC void fmt::SystemError::init(
@@ -397,12 +424,12 @@ int fmt::internal::CharTraits<wchar_t>::format_float(
     unsigned width, int precision, T value) {
   if (width == 0) {
     return precision < 0 ?
-               swprintf(buffer, size, format, value) :
-               swprintf(buffer, size, format, precision, value);
+        FMT_SWPRINTF(buffer, size, format, value) :
+        FMT_SWPRINTF(buffer, size, format, precision, value);
   }
   return precision < 0 ?
-           swprintf(buffer, size, format, width, value) :
-           swprintf(buffer, size, format, width, precision, value);
+      FMT_SWPRINTF(buffer, size, format, width, value) :
+      FMT_SWPRINTF(buffer, size, format, width, precision, value);
 }
 
 template <typename T>
@@ -440,6 +467,7 @@ const uint64_t fmt::internal::BasicData<T>::POWERS_OF_10_64[] = {
 };
 
 FMT_FUNC void fmt::internal::report_unknown_type(char code, const char *type) {
+  (void)type;
   if (std::isprint(static_cast<unsigned char>(code))) {
     FMT_THROW(fmt::FormatError(
         fmt::format("unknown format code '{}' for {}", code, type)));
@@ -525,12 +553,8 @@ FMT_FUNC void fmt::internal::format_windows_error(
 
    public:
     String() : str_() {}
-        ~String() {
-            LocalFree(str_);
-        }
-        LPWSTR *ptr() {
-            return &str_;
-        }
+    ~String() { LocalFree(str_); }
+    LPWSTR *ptr() { return &str_; }
     LPCWSTR c_str() const { return str_; }
   };
   FMT_TRY {
@@ -568,14 +592,10 @@ public:
   : formatter_(f), writer_(f.writer()), spec_(s), format_(fmt) {}
 
   template <typename T>
-    void visit_any_int(T value) {
-        writer_.write_int(value, spec_);
-    }
+  void visit_any_int(T value) { writer_.write_int(value, spec_); }
 
   template <typename T>
-    void visit_any_double(T value) {
-        writer_.write_double(value, spec_);
-    }
+  void visit_any_double(T value) { writer_.write_double(value, spec_); }
 
   void visit_char(int value) {
     if (spec_.type_ && spec_.type_ != 'c') {
@@ -597,15 +617,12 @@ public:
       if (spec_.align_ == fmt::ALIGN_RIGHT) {
         std::fill_n(out, spec_.width_ - 1, fill);
         out += spec_.width_ - 1;
-            }
-            else if (spec_.align_ == fmt::ALIGN_CENTER) {
+      } else if (spec_.align_ == fmt::ALIGN_CENTER) {
         out = writer_.fill_padding(out, spec_.width_, 1, fill);
-            }
-            else {
+      } else {
         std::fill_n(out + 1, spec_.width_ - 1, fill);
       }
-        }
-        else {
+    } else {
       out = writer_.grow_buffer(1);
     }
     *out = static_cast<Char>(value);
@@ -631,6 +648,11 @@ public:
   }
 };
 
+template <typename Char>
+void fmt::internal::FixedBuffer<Char>::grow(std::size_t) {
+  FMT_THROW(std::runtime_error("buffer overflow"));
+}
+
 template <typename Char>
 template <typename StrChar>
 void fmt::BasicWriter<Char>::write_str(
@@ -720,6 +742,7 @@ void fmt::internal::PrintfFormatter<Char>::parse_flags(
 template <typename Char>
 Arg fmt::internal::PrintfFormatter<Char>::get_arg(
     const Char *s, unsigned arg_index) {
+  (void)s;
   const char *error = 0;
   Arg arg = arg_index == UINT_MAX ?
     next_arg(error) : FormatterBase::get_arg(arg_index - 1, error);
@@ -740,8 +763,7 @@ unsigned fmt::internal::PrintfFormatter<Char>::parse_header(
     if (*s == '$') {  // value is an argument index
       ++s;
       arg_index = value;
-        }
-        else {
+    } else {
       if (c == '0')
         spec.fill_ = '0';
       if (value != 0) {
@@ -756,8 +778,7 @@ unsigned fmt::internal::PrintfFormatter<Char>::parse_header(
   // Parse width.
   if (*s >= '0' && *s <= '9') {
     spec.width_ = parse_nonnegative_int(s);
-    }
-    else if (*s == '*') {
+  } else if (*s == '*') {
     ++s;
     spec.width_ = WidthHandler(spec).visit(get_arg(s));
   }
@@ -792,8 +813,7 @@ void fmt::internal::PrintfFormatter<Char>::format(
       ++s;
       if ('0' <= *s && *s <= '9') {
         spec.precision_ = parse_nonnegative_int(s);
-            }
-            else if (*s == '*') {
+      } else if (*s == '*') {
         ++s;
         spec.precision_ = PrecisionHandler().visit(get_arg(s));
       }
@@ -848,8 +868,7 @@ void fmt::internal::PrintfFormatter<Char>::format(
     if (arg.type <= Arg::LAST_INTEGER_TYPE) {
       // Normalize type.
       switch (spec.type_) {
-            case 'i':
-            case 'u':
+      case 'i': case 'u':
         spec.type_ = 'd';
         break;
       case 'c':
@@ -886,12 +905,10 @@ void fmt::internal::PrintfFormatter<Char>::format(
         if (spec.align_ != ALIGN_LEFT) {
           std::fill_n(out, spec.width_ - 1, fill);
           out += spec.width_ - 1;
-                }
-                else {
+        } else {
           std::fill_n(out + 1, spec.width_ - 1, fill);
         }
-            }
-            else {
+      } else {
         out = writer.grow_buffer(1);
       }
       *out = static_cast<Char>(arg.int_value);
@@ -972,8 +989,7 @@ const Char *fmt::BasicFormatter<Char>::format(
               FMT_THROW(FormatError("invalid fill character '{'"));
             s += 2;
             spec.fill_ = c;
-                    }
-                    else ++s;
+          } else ++s;
           if (spec.align_ == ALIGN_NUMERIC)
             require_numeric_argument(arg, '=');
           break;
@@ -1021,8 +1037,7 @@ const Char *fmt::BasicFormatter<Char>::format(
       spec.precision_ = 0;
       if ('0' <= *s && *s <= '9') {
         spec.precision_ = parse_nonnegative_int(s);
-            }
-            else if (*s == '{') {
+      } else if (*s == '{') {
         ++s;
         const Arg &precision_arg = parse_arg_index(s);
         if (*s++ != '}')
@@ -1051,8 +1066,7 @@ const Char *fmt::BasicFormatter<Char>::format(
         if (value > INT_MAX)
           FMT_THROW(FormatError("number is too big"));
         spec.precision_ = static_cast<int>(value);
-            }
-            else {
+      } else {
         FMT_THROW(FormatError("missing precision specifier"));
       }
       if (arg.type < Arg::LAST_INTEGER_TYPE || arg.type == Arg::POINTER) {
@@ -1141,8 +1155,12 @@ FMT_FUNC int fmt::fprintf(std::FILE *f, StringRef format, ArgList args) {
   return std::fwrite(w.data(), 1, size, f) < size ? -1 : static_cast<int>(size);
 }
 
+#ifndef FMT_HEADER_ONLY
+
 // Explicit instantiations for char.
 
+template void fmt::internal::FixedBuffer<char>::grow(std::size_t);
+
 template const char *fmt::BasicFormatter<char>::format(
     const char *&format_str, const fmt::internal::Arg &arg);
 
@@ -1162,6 +1180,8 @@ template int fmt::internal::CharTraits<char>::format_float(
 
 // Explicit instantiations for wchar_t.
 
+template void fmt::internal::FixedBuffer<wchar_t>::grow(std::size_t);
+
 template const wchar_t *fmt::BasicFormatter<wchar_t>::format(
     const wchar_t *&format_str, const fmt::internal::Arg &arg);
 
@@ -1180,6 +1200,8 @@ template int fmt::internal::CharTraits<wchar_t>::format_float(
     wchar_t *buffer, std::size_t size, const wchar_t *format,
     unsigned width, int precision, long double value);
 
+#endif  // FMT_HEADER_ONLY
+
 #if _MSC_VER
 # pragma warning(pop)
 #endif