mirror of
https://github.com/luau-lang/luau.git
synced 2024-11-15 14:25:44 +08:00
67ce75e870
# What's changed? ### Native Code Generation * Fixed an UAF relating to reusing a hash key after a weak table has undergone some GC. * Fixed a bounds check on arm64 to allow access to the last byte of a buffer. ### New Type Solver * Type states now preserves error-suppression, i.e. `local x: any = 5` and `x.foo` does not error. * Made error-suppression logic in subtyping more accurate. * Subtyping now knows how to reduce type families. * Fixed function call overload resolution so that the return type resolves to the correct overload. * Fixed a case where we attempted to reduce irreducible type families a few too many times, leading to duplicate errors. * Type checker needs to type check annotations in function signatures to be able to report errors relating to those annotations. * Fixed an UAF from a pointer to stack-allocated data in Subtyping's `explainReasonings`. ### Nonstrict Type Checker * Fixed a crash when calling a checked function of the form `math.abs` with an incorrect argument type. * Fixed a crash when calling a checked function with a number of arguments that did not exactly match the number of parameters required. --- ### Internal Contributors Co-authored-by: Aaron Weiss <aaronweiss@roblox.com> Co-authored-by: Andy Friesen <afriesen@roblox.com> Co-authored-by: Vyacheslav Egorov <vegorov@roblox.com> --------- Co-authored-by: Aaron Weiss <aaronweiss@roblox.com> Co-authored-by: Andy Friesen <afriesen@roblox.com> Co-authored-by: Vighnesh <vvijay@roblox.com> Co-authored-by: Aviral Goel <agoel@roblox.com> Co-authored-by: David Cope <dcope@roblox.com> Co-authored-by: Lily Brown <lbrown@roblox.com> Co-authored-by: Vyacheslav Egorov <vegorov@roblox.com>
71 lines
2.4 KiB
C++
71 lines
2.4 KiB
C++
// This file is part of the Luau programming language and is licensed under MIT License; see LICENSE.txt for details
|
|
#pragma once
|
|
|
|
#include "Luau/Ast.h"
|
|
#include "Luau/InsertionOrderedMap.h"
|
|
#include "Luau/NotNull.h"
|
|
#include "Luau/TypeFwd.h"
|
|
#include "Luau/Location.h"
|
|
#include "Luau/Error.h"
|
|
#include "Luau/Subtyping.h"
|
|
|
|
namespace Luau
|
|
{
|
|
|
|
struct BuiltinTypes;
|
|
struct TypeArena;
|
|
struct Scope;
|
|
struct InternalErrorReporter;
|
|
struct TypeCheckLimits;
|
|
struct Subtyping;
|
|
|
|
class Normalizer;
|
|
|
|
struct OverloadResolver
|
|
{
|
|
enum Analysis
|
|
{
|
|
Ok,
|
|
TypeIsNotAFunction,
|
|
ArityMismatch,
|
|
OverloadIsNonviable, // Arguments were incompatible with the overloads parameters but were otherwise compatible by arity
|
|
};
|
|
|
|
OverloadResolver(NotNull<BuiltinTypes> builtinTypes, NotNull<TypeArena> arena, NotNull<Normalizer> normalizer, NotNull<Scope> scope,
|
|
NotNull<InternalErrorReporter> reporter, NotNull<TypeCheckLimits> limits, Location callLocation);
|
|
|
|
NotNull<BuiltinTypes> builtinTypes;
|
|
NotNull<TypeArena> arena;
|
|
NotNull<Normalizer> normalizer;
|
|
NotNull<Scope> scope;
|
|
NotNull<InternalErrorReporter> ice;
|
|
NotNull<TypeCheckLimits> limits;
|
|
Subtyping subtyping;
|
|
Location callLoc;
|
|
|
|
// Resolver results
|
|
std::vector<TypeId> ok;
|
|
std::vector<TypeId> nonFunctions;
|
|
std::vector<std::pair<TypeId, ErrorVec>> arityMismatches;
|
|
std::vector<std::pair<TypeId, ErrorVec>> nonviableOverloads;
|
|
InsertionOrderedMap<TypeId, std::pair<OverloadResolver::Analysis, size_t>> resolution;
|
|
|
|
|
|
std::pair<OverloadResolver::Analysis, TypeId> selectOverload(TypeId ty, TypePackId args);
|
|
void resolve(TypeId fnTy, const TypePack* args, AstExpr* selfExpr, const std::vector<AstExpr*>* argExprs);
|
|
|
|
private:
|
|
std::optional<ErrorVec> testIsSubtype(const Location& location, TypeId subTy, TypeId superTy);
|
|
std::optional<ErrorVec> testIsSubtype(const Location& location, TypePackId subTy, TypePackId superTy);
|
|
std::pair<Analysis, ErrorVec> checkOverload(
|
|
TypeId fnTy, const TypePack* args, AstExpr* fnLoc, const std::vector<AstExpr*>* argExprs, bool callMetamethodOk = true);
|
|
static bool isLiteral(AstExpr* expr);
|
|
LUAU_NOINLINE
|
|
std::pair<Analysis, ErrorVec> checkOverload_(
|
|
TypeId fnTy, const FunctionType* fn, const TypePack* args, AstExpr* fnExpr, const std::vector<AstExpr*>* argExprs);
|
|
size_t indexof(Analysis analysis);
|
|
void add(Analysis analysis, TypeId ty, ErrorVec&& errors);
|
|
};
|
|
|
|
} // namespace Luau
|