mirror of
https://github.com/luau-lang/luau.git
synced 2024-11-15 14:25:44 +08:00
9c2146288d
# What's changed? * Support for new 'require by string' RFC with relative paths and aliases in now enabled in Luau REPL application ### New Type Solver * Fixed assertion failure on generic table keys (`[expr] = value`) * Fixed an issue with type substitution traversing into the substituted parts during type instantiation * Fixed crash in union simplification when that union contained uninhabited unions and other types inside * Union types in binary type families like `add<a | b, c>` are expanded into `add<a, c> | add<b, c>` to handle * Added handling for type family solving creating new type families * Fixed a bug with normalization operation caching types with unsolved parts * Tables with uninhabited properties are now simplified to `never` * Fixed failures found by fuzzer ### Native Code Generation * Added support for shared code generation between multiple Luau VM instances * Fixed issue in load-store propagation and new tagged LOAD_TVALUE instructions * Fixed issues with partial register dead store elimination causing failures in GC assists --- ### Internal Contributors Co-authored-by: Aaron Weiss <aaronweiss@roblox.com> Co-authored-by: Alexander McCord <amccord@roblox.com> Co-authored-by: Andy Friesen <afriesen@roblox.com> Co-authored-by: James McNellis <jmcnellis@roblox.com> Co-authored-by: Vighnesh Vijay <vvijay@roblox.com> Co-authored-by: Vyacheslav Egorov <vegorov@roblox.com>
1064 lines
30 KiB
C++
1064 lines
30 KiB
C++
// This file is part of the Luau programming language and is licensed under MIT License; see LICENSE.txt for details
|
|
#include "Fixture.h"
|
|
#include "doctest.h"
|
|
|
|
using namespace Luau;
|
|
|
|
LUAU_FASTFLAG(LuauTinyControlFlowAnalysis);
|
|
|
|
TEST_SUITE_BEGIN("ControlFlowAnalysis");
|
|
|
|
TEST_CASE_FIXTURE(BuiltinsFixture, "if_not_x_return")
|
|
{
|
|
ScopedFastFlag sff{FFlag::LuauTinyControlFlowAnalysis, true};
|
|
|
|
CheckResult result = check(R"(
|
|
local function f(x: string?)
|
|
if not x then
|
|
return
|
|
end
|
|
|
|
local foo = x
|
|
end
|
|
)");
|
|
|
|
LUAU_REQUIRE_NO_ERRORS(result);
|
|
CHECK_EQ("string", toString(requireTypeAtPosition({6, 24})));
|
|
}
|
|
|
|
TEST_CASE_FIXTURE(BuiltinsFixture, "if_not_x_break")
|
|
{
|
|
ScopedFastFlag sff{FFlag::LuauTinyControlFlowAnalysis, true};
|
|
|
|
CheckResult result = check(R"(
|
|
local function f(x: {{value: string?}})
|
|
for _, record in x do
|
|
if not record.value then
|
|
break
|
|
end
|
|
|
|
local foo = record.value
|
|
end
|
|
end
|
|
)");
|
|
|
|
LUAU_REQUIRE_NO_ERRORS(result);
|
|
CHECK_EQ("string", toString(requireTypeAtPosition({7, 34})));
|
|
}
|
|
|
|
TEST_CASE_FIXTURE(BuiltinsFixture, "if_not_x_continue")
|
|
{
|
|
ScopedFastFlag sff{FFlag::LuauTinyControlFlowAnalysis, true};
|
|
|
|
CheckResult result = check(R"(
|
|
local function f(x: {{value: string?}})
|
|
for _, record in x do
|
|
if not record.value then
|
|
continue
|
|
end
|
|
|
|
local foo = record.value
|
|
end
|
|
end
|
|
)");
|
|
|
|
LUAU_REQUIRE_NO_ERRORS(result);
|
|
CHECK_EQ("string", toString(requireTypeAtPosition({7, 38})));
|
|
}
|
|
|
|
TEST_CASE_FIXTURE(BuiltinsFixture, "if_not_x_return_elif_not_y_return")
|
|
{
|
|
ScopedFastFlag sff{FFlag::LuauTinyControlFlowAnalysis, true};
|
|
|
|
CheckResult result = check(R"(
|
|
local function f(x: string?, y: string?)
|
|
if not x then
|
|
return
|
|
elseif not y then
|
|
return
|
|
end
|
|
|
|
local foo = x
|
|
local bar = y
|
|
end
|
|
)");
|
|
|
|
LUAU_REQUIRE_NO_ERRORS(result);
|
|
CHECK_EQ("string", toString(requireTypeAtPosition({8, 24})));
|
|
CHECK_EQ("string", toString(requireTypeAtPosition({9, 24})));
|
|
}
|
|
|
|
TEST_CASE_FIXTURE(BuiltinsFixture, "if_not_x_break_elif_not_y_break")
|
|
{
|
|
ScopedFastFlag sff{FFlag::LuauTinyControlFlowAnalysis, true};
|
|
|
|
CheckResult result = check(R"(
|
|
local function f(x: {{value: string?}}, y: {{value: string?}})
|
|
for i, recordX in x do
|
|
local recordY = y[i]
|
|
if not recordX.value then
|
|
break
|
|
elseif not recordY.value then
|
|
break
|
|
end
|
|
|
|
local foo = recordX.value
|
|
local bar = recordY.value
|
|
end
|
|
end
|
|
)");
|
|
|
|
LUAU_REQUIRE_NO_ERRORS(result);
|
|
CHECK_EQ("string", toString(requireTypeAtPosition({10, 38})));
|
|
CHECK_EQ("string", toString(requireTypeAtPosition({11, 38})));
|
|
}
|
|
|
|
TEST_CASE_FIXTURE(BuiltinsFixture, "if_not_x_continue_elif_not_y_continue")
|
|
{
|
|
ScopedFastFlag sff{FFlag::LuauTinyControlFlowAnalysis, true};
|
|
|
|
CheckResult result = check(R"(
|
|
local function f(x: {{value: string?}}, y: {{value: string?}})
|
|
for i, recordX in x do
|
|
local recordY = y[i]
|
|
if not recordX.value then
|
|
continue
|
|
elseif not recordY.value then
|
|
continue
|
|
end
|
|
|
|
local foo = recordX.value
|
|
local bar = recordY.value
|
|
end
|
|
end
|
|
)");
|
|
|
|
LUAU_REQUIRE_NO_ERRORS(result);
|
|
CHECK_EQ("string", toString(requireTypeAtPosition({10, 38})));
|
|
CHECK_EQ("string", toString(requireTypeAtPosition({11, 38})));
|
|
}
|
|
|
|
TEST_CASE_FIXTURE(BuiltinsFixture, "if_not_x_return_elif_not_y_break")
|
|
{
|
|
ScopedFastFlag sff{FFlag::LuauTinyControlFlowAnalysis, true};
|
|
|
|
CheckResult result = check(R"(
|
|
local function f(x: {{value: string?}}, y: {{value: string?}})
|
|
for i, recordX in x do
|
|
local recordY = y[i]
|
|
if not recordX.value then
|
|
return
|
|
elseif not recordY.value then
|
|
break
|
|
end
|
|
|
|
local foo = recordX.value
|
|
local bar = recordY.value
|
|
end
|
|
end
|
|
)");
|
|
|
|
LUAU_REQUIRE_NO_ERRORS(result);
|
|
CHECK_EQ("string", toString(requireTypeAtPosition({10, 38})));
|
|
CHECK_EQ("string", toString(requireTypeAtPosition({11, 38})));
|
|
}
|
|
|
|
TEST_CASE_FIXTURE(BuiltinsFixture, "if_not_x_break_elif_not_y_continue")
|
|
{
|
|
ScopedFastFlag sff{FFlag::LuauTinyControlFlowAnalysis, true};
|
|
|
|
CheckResult result = check(R"(
|
|
local function f(x: {{value: string?}}, y: {{value: string?}})
|
|
for i, recordX in x do
|
|
local recordY = y[i]
|
|
if not recordX.value then
|
|
break
|
|
elseif not recordY.value then
|
|
continue
|
|
end
|
|
|
|
local foo = recordX.value
|
|
local bar = recordY.value
|
|
end
|
|
end
|
|
)");
|
|
|
|
LUAU_REQUIRE_NO_ERRORS(result);
|
|
CHECK_EQ("string", toString(requireTypeAtPosition({10, 38})));
|
|
CHECK_EQ("string", toString(requireTypeAtPosition({11, 38})));
|
|
}
|
|
|
|
TEST_CASE_FIXTURE(BuiltinsFixture, "if_not_x_return_elif_rand_return_elif_not_y_return")
|
|
{
|
|
ScopedFastFlag sff{FFlag::LuauTinyControlFlowAnalysis, true};
|
|
|
|
CheckResult result = check(R"(
|
|
local function f(x: string?, y: string?)
|
|
if not x then
|
|
return
|
|
elseif math.random() > 0.5 then
|
|
return
|
|
elseif not y then
|
|
return
|
|
end
|
|
|
|
local foo = x
|
|
local bar = y
|
|
end
|
|
)");
|
|
|
|
LUAU_REQUIRE_NO_ERRORS(result);
|
|
CHECK_EQ("string", toString(requireTypeAtPosition({10, 24})));
|
|
CHECK_EQ("string", toString(requireTypeAtPosition({11, 24})));
|
|
}
|
|
|
|
TEST_CASE_FIXTURE(BuiltinsFixture, "if_not_x_break_elif_rand_break_elif_not_y_break")
|
|
{
|
|
ScopedFastFlag sff{FFlag::LuauTinyControlFlowAnalysis, true};
|
|
|
|
CheckResult result = check(R"(
|
|
local function f(x: {{value: string?}}, y: {{value: string?}})
|
|
for i, recordX in x do
|
|
local recordY = y[i]
|
|
if not recordX.value then
|
|
break
|
|
elseif math.random() > 0.5 then
|
|
break
|
|
elseif not recordY.value then
|
|
break
|
|
end
|
|
|
|
local foo = recordX.value
|
|
local bar = recordY.value
|
|
end
|
|
end
|
|
)");
|
|
|
|
LUAU_REQUIRE_NO_ERRORS(result);
|
|
CHECK_EQ("string", toString(requireTypeAtPosition({12, 38})));
|
|
CHECK_EQ("string", toString(requireTypeAtPosition({13, 38})));
|
|
}
|
|
|
|
TEST_CASE_FIXTURE(BuiltinsFixture, "if_not_x_continue_elif_rand_continue_elif_not_y_continue")
|
|
{
|
|
ScopedFastFlag sff{FFlag::LuauTinyControlFlowAnalysis, true};
|
|
|
|
CheckResult result = check(R"(
|
|
local function f(x: {{value: string?}}, y: {{value: string?}})
|
|
for i, recordX in x do
|
|
local recordY = y[i]
|
|
if not recordX.value then
|
|
continue
|
|
elseif math.random() > 0.5 then
|
|
continue
|
|
elseif not recordY.value then
|
|
continue
|
|
end
|
|
|
|
local foo = recordX.value
|
|
local bar = recordY.value
|
|
end
|
|
end
|
|
)");
|
|
|
|
LUAU_REQUIRE_NO_ERRORS(result);
|
|
CHECK_EQ("string", toString(requireTypeAtPosition({12, 38})));
|
|
CHECK_EQ("string", toString(requireTypeAtPosition({13, 38})));
|
|
}
|
|
|
|
TEST_CASE_FIXTURE(BuiltinsFixture, "if_not_x_return_elif_not_rand_return_elif_not_y_fallthrough")
|
|
{
|
|
ScopedFastFlag sff{FFlag::LuauTinyControlFlowAnalysis, true};
|
|
|
|
CheckResult result = check(R"(
|
|
local function f(x: string?, y: string?)
|
|
if not x then
|
|
return
|
|
elseif math.random() > 0.5 then
|
|
return
|
|
elseif not y then
|
|
|
|
end
|
|
|
|
local foo = x
|
|
local bar = y
|
|
end
|
|
)");
|
|
|
|
LUAU_REQUIRE_NO_ERRORS(result);
|
|
CHECK_EQ("string", toString(requireTypeAtPosition({10, 24})));
|
|
CHECK_EQ("string?", toString(requireTypeAtPosition({11, 24})));
|
|
}
|
|
|
|
TEST_CASE_FIXTURE(BuiltinsFixture, "if_not_x_break_elif_rand_break_elif_not_y_fallthrough")
|
|
{
|
|
ScopedFastFlag sff{FFlag::LuauTinyControlFlowAnalysis, true};
|
|
|
|
CheckResult result = check(R"(
|
|
local function f(x: {{value: string?}}, y: {{value: string?}})
|
|
for i, recordX in x do
|
|
local recordY = y[i]
|
|
if not recordX.value then
|
|
break
|
|
elseif math.random() > 0.5 then
|
|
break
|
|
elseif not recordY.value then
|
|
|
|
end
|
|
|
|
local foo = recordX.value
|
|
local bar = recordY.value
|
|
end
|
|
end
|
|
)");
|
|
|
|
LUAU_REQUIRE_NO_ERRORS(result);
|
|
CHECK_EQ("string", toString(requireTypeAtPosition({12, 38})));
|
|
CHECK_EQ("string?", toString(requireTypeAtPosition({13, 38})));
|
|
}
|
|
|
|
TEST_CASE_FIXTURE(BuiltinsFixture, "if_not_x_continue_elif_rand_continue_elif_not_y_fallthrough")
|
|
{
|
|
ScopedFastFlag sff{FFlag::LuauTinyControlFlowAnalysis, true};
|
|
|
|
CheckResult result = check(R"(
|
|
local function f(x: {{value: string?}}, y: {{value: string?}})
|
|
for i, recordX in x do
|
|
local recordY = y[i]
|
|
if not recordX.value then
|
|
continue
|
|
elseif math.random() > 0.5 then
|
|
continue
|
|
elseif not recordY.value then
|
|
|
|
end
|
|
|
|
local foo = recordX.value
|
|
local bar = recordY.value
|
|
end
|
|
end
|
|
)");
|
|
|
|
LUAU_REQUIRE_NO_ERRORS(result);
|
|
CHECK_EQ("string", toString(requireTypeAtPosition({12, 38})));
|
|
CHECK_EQ("string?", toString(requireTypeAtPosition({13, 38})));
|
|
}
|
|
|
|
TEST_CASE_FIXTURE(BuiltinsFixture, "if_not_x_return_elif_not_y_fallthrough_elif_not_z_return")
|
|
{
|
|
ScopedFastFlag sff{FFlag::LuauTinyControlFlowAnalysis, true};
|
|
|
|
CheckResult result = check(R"(
|
|
local function f(x: string?, y: string?, z: string?)
|
|
if not x then
|
|
return
|
|
elseif not y then
|
|
|
|
elseif not z then
|
|
return
|
|
end
|
|
|
|
local foo = x
|
|
local bar = y
|
|
local baz = z
|
|
end
|
|
)");
|
|
|
|
LUAU_REQUIRE_NO_ERRORS(result);
|
|
CHECK_EQ("string", toString(requireTypeAtPosition({10, 24})));
|
|
CHECK_EQ("string?", toString(requireTypeAtPosition({11, 24})));
|
|
CHECK_EQ("string?", toString(requireTypeAtPosition({12, 24})));
|
|
}
|
|
|
|
TEST_CASE_FIXTURE(BuiltinsFixture, "if_not_x_break_elif_not_y_fallthrough_elif_not_z_break")
|
|
{
|
|
ScopedFastFlag sff{FFlag::LuauTinyControlFlowAnalysis, true};
|
|
|
|
CheckResult result = check(R"(
|
|
local function f(x: {{value: string?}}, y: {{value: string?}}, z: {{value: string?}})
|
|
for i, recordX in x do
|
|
local recordY = y[i]
|
|
local recordZ = y[i]
|
|
if not recordX.value then
|
|
break
|
|
elseif not recordY.value then
|
|
|
|
elseif not recordZ.value then
|
|
break
|
|
end
|
|
|
|
local foo = recordX.value
|
|
local bar = recordY.value
|
|
local baz = recordZ.value
|
|
end
|
|
end
|
|
)");
|
|
|
|
LUAU_REQUIRE_NO_ERRORS(result);
|
|
CHECK_EQ("string", toString(requireTypeAtPosition({13, 38})));
|
|
CHECK_EQ("string?", toString(requireTypeAtPosition({14, 38})));
|
|
CHECK_EQ("string?", toString(requireTypeAtPosition({15, 38})));
|
|
}
|
|
|
|
TEST_CASE_FIXTURE(BuiltinsFixture, "if_not_x_continue_elif_not_y_fallthrough_elif_not_z_continue")
|
|
{
|
|
ScopedFastFlag sff{FFlag::LuauTinyControlFlowAnalysis, true};
|
|
|
|
CheckResult result = check(R"(
|
|
local function f(x: {{value: string?}}, y: {{value: string?}}, z: {{value: string?}})
|
|
for i, recordX in x do
|
|
local recordY = y[i]
|
|
local recordZ = y[i]
|
|
if not recordX.value then
|
|
continue
|
|
elseif not recordY.value then
|
|
|
|
elseif not recordZ.value then
|
|
continue
|
|
end
|
|
|
|
local foo = recordX.value
|
|
local bar = recordY.value
|
|
local baz = recordZ.value
|
|
end
|
|
end
|
|
)");
|
|
|
|
LUAU_REQUIRE_NO_ERRORS(result);
|
|
CHECK_EQ("string", toString(requireTypeAtPosition({13, 38})));
|
|
CHECK_EQ("string?", toString(requireTypeAtPosition({14, 38})));
|
|
CHECK_EQ("string?", toString(requireTypeAtPosition({15, 38})));
|
|
}
|
|
|
|
TEST_CASE_FIXTURE(BuiltinsFixture, "if_not_x_continue_elif_not_y_throw_elif_not_z_fallthrough")
|
|
{
|
|
ScopedFastFlag sff{FFlag::LuauTinyControlFlowAnalysis, true};
|
|
|
|
CheckResult result = check(R"(
|
|
local function f(x: {{value: string?}}, y: {{value: string?}}, z: {{value: string?}})
|
|
for i, recordX in x do
|
|
local recordY = y[i]
|
|
local recordZ = y[i]
|
|
if not recordX.value then
|
|
continue
|
|
elseif not recordY.value then
|
|
error("Y value not defined")
|
|
elseif not recordZ.value then
|
|
|
|
end
|
|
|
|
local foo = recordX.value
|
|
local bar = recordY.value
|
|
local baz = recordZ.value
|
|
end
|
|
end
|
|
)");
|
|
|
|
LUAU_REQUIRE_NO_ERRORS(result);
|
|
CHECK_EQ("string", toString(requireTypeAtPosition({13, 38})));
|
|
CHECK_EQ("string", toString(requireTypeAtPosition({14, 38})));
|
|
CHECK_EQ("string?", toString(requireTypeAtPosition({15, 38})));
|
|
}
|
|
|
|
TEST_CASE_FIXTURE(BuiltinsFixture, "if_not_x_return_elif_not_y_fallthrough_elif_not_z_break")
|
|
{
|
|
ScopedFastFlag sff{FFlag::LuauTinyControlFlowAnalysis, true};
|
|
|
|
CheckResult result = check(R"(
|
|
local function f(x: {{value: string?}}, y: {{value: string?}}, z: {{value: string?}})
|
|
for i, recordX in x do
|
|
local recordY = y[i]
|
|
local recordZ = y[i]
|
|
if not recordX.value then
|
|
return
|
|
elseif not recordY.value then
|
|
|
|
elseif not recordZ.value then
|
|
break
|
|
end
|
|
|
|
local foo = recordX.value
|
|
local bar = recordY.value
|
|
local baz = recordZ.value
|
|
end
|
|
end
|
|
)");
|
|
|
|
LUAU_REQUIRE_NO_ERRORS(result);
|
|
CHECK_EQ("string", toString(requireTypeAtPosition({13, 38})));
|
|
CHECK_EQ("string?", toString(requireTypeAtPosition({14, 38})));
|
|
CHECK_EQ("string?", toString(requireTypeAtPosition({15, 38})));
|
|
}
|
|
|
|
TEST_CASE_FIXTURE(BuiltinsFixture, "do_if_not_x_return")
|
|
{
|
|
ScopedFastFlag sff{FFlag::LuauTinyControlFlowAnalysis, true};
|
|
|
|
CheckResult result = check(R"(
|
|
local function f(x: string?)
|
|
do
|
|
if not x then
|
|
return
|
|
end
|
|
end
|
|
|
|
local foo = x
|
|
end
|
|
)");
|
|
|
|
LUAU_REQUIRE_NO_ERRORS(result);
|
|
CHECK_EQ("string", toString(requireTypeAtPosition({8, 24})));
|
|
}
|
|
|
|
TEST_CASE_FIXTURE(BuiltinsFixture, "for_record_do_if_not_x_break")
|
|
{
|
|
ScopedFastFlag sff{FFlag::LuauTinyControlFlowAnalysis, true};
|
|
|
|
CheckResult result = check(R"(
|
|
local function f(x: {{value: string?}})
|
|
for _, record in x do
|
|
do
|
|
if not record.value then
|
|
break
|
|
end
|
|
end
|
|
|
|
local foo = record.value
|
|
end
|
|
end
|
|
)");
|
|
|
|
LUAU_REQUIRE_NO_ERRORS(result);
|
|
CHECK_EQ("string", toString(requireTypeAtPosition({9, 38})));
|
|
}
|
|
|
|
TEST_CASE_FIXTURE(BuiltinsFixture, "for_record_do_if_not_x_continue")
|
|
{
|
|
ScopedFastFlag sff{FFlag::LuauTinyControlFlowAnalysis, true};
|
|
|
|
CheckResult result = check(R"(
|
|
local function f(x: {{value: string?}})
|
|
for _, record in x do
|
|
do
|
|
if not record.value then
|
|
continue
|
|
end
|
|
end
|
|
|
|
local foo = record.value
|
|
end
|
|
end
|
|
)");
|
|
|
|
LUAU_REQUIRE_NO_ERRORS(result);
|
|
CHECK_EQ("string", toString(requireTypeAtPosition({9, 38})));
|
|
}
|
|
|
|
TEST_CASE_FIXTURE(BuiltinsFixture, "early_return_in_a_loop_which_isnt_guaranteed_to_run_first")
|
|
{
|
|
ScopedFastFlag sff{FFlag::LuauTinyControlFlowAnalysis, true};
|
|
|
|
CheckResult result = check(R"(
|
|
local function f(x: string?)
|
|
while math.random() > 0.5 do
|
|
if not x then
|
|
return
|
|
end
|
|
|
|
local foo = x
|
|
end
|
|
|
|
local bar = x
|
|
end
|
|
)");
|
|
|
|
LUAU_REQUIRE_NO_ERRORS(result);
|
|
CHECK_EQ("string", toString(requireTypeAtPosition({7, 28})));
|
|
CHECK_EQ("string?", toString(requireTypeAtPosition({10, 24})));
|
|
}
|
|
|
|
TEST_CASE_FIXTURE(BuiltinsFixture, "early_return_in_a_loop_which_is_guaranteed_to_run_first")
|
|
{
|
|
ScopedFastFlag sff{FFlag::LuauTinyControlFlowAnalysis, true};
|
|
|
|
CheckResult result = check(R"(
|
|
local function f(x: string?)
|
|
repeat
|
|
if not x then
|
|
return
|
|
end
|
|
|
|
local foo = x
|
|
until math.random() > 0.5
|
|
|
|
local bar = x
|
|
end
|
|
)");
|
|
|
|
LUAU_REQUIRE_NO_ERRORS(result);
|
|
CHECK_EQ("string", toString(requireTypeAtPosition({7, 28})));
|
|
CHECK_EQ("string?", toString(requireTypeAtPosition({10, 24}))); // TODO: This is wrong, should be `string`.
|
|
}
|
|
|
|
TEST_CASE_FIXTURE(BuiltinsFixture, "early_return_in_a_loop_which_is_guaranteed_to_run_first_2")
|
|
{
|
|
ScopedFastFlag sff{FFlag::LuauTinyControlFlowAnalysis, true};
|
|
|
|
CheckResult result = check(R"(
|
|
local function f(x: string?)
|
|
for i = 1, 10 do
|
|
if not x then
|
|
return
|
|
end
|
|
|
|
local foo = x
|
|
end
|
|
|
|
local bar = x
|
|
end
|
|
)");
|
|
|
|
LUAU_REQUIRE_NO_ERRORS(result);
|
|
CHECK_EQ("string", toString(requireTypeAtPosition({7, 28})));
|
|
CHECK_EQ("string?", toString(requireTypeAtPosition({10, 24}))); // TODO: This is wrong, should be `string`.
|
|
}
|
|
|
|
TEST_CASE_FIXTURE(BuiltinsFixture, "if_not_x_then_error")
|
|
{
|
|
ScopedFastFlag sff{FFlag::LuauTinyControlFlowAnalysis, true};
|
|
|
|
CheckResult result = check(R"(
|
|
local function f(x: string?)
|
|
if not x then
|
|
error("oops")
|
|
end
|
|
|
|
local foo = x
|
|
end
|
|
)");
|
|
|
|
LUAU_REQUIRE_NO_ERRORS(result);
|
|
CHECK_EQ("string", toString(requireTypeAtPosition({6, 24})));
|
|
}
|
|
|
|
TEST_CASE_FIXTURE(BuiltinsFixture, "if_not_x_then_assert_false")
|
|
{
|
|
ScopedFastFlag sff{FFlag::LuauTinyControlFlowAnalysis, true};
|
|
|
|
CheckResult result = check(R"(
|
|
local function f(x: string?)
|
|
if not x then
|
|
assert(false)
|
|
end
|
|
|
|
local foo = x
|
|
end
|
|
)");
|
|
|
|
LUAU_REQUIRE_NO_ERRORS(result);
|
|
CHECK_EQ("string", toString(requireTypeAtPosition({6, 24})));
|
|
}
|
|
|
|
TEST_CASE_FIXTURE(BuiltinsFixture, "if_not_x_return_if_not_y_return")
|
|
{
|
|
ScopedFastFlag sff{FFlag::LuauTinyControlFlowAnalysis, true};
|
|
|
|
CheckResult result = check(R"(
|
|
local function f(x: string?, y: string?)
|
|
if not x then
|
|
return
|
|
end
|
|
|
|
if not y then
|
|
return
|
|
end
|
|
|
|
local foo = x
|
|
local bar = y
|
|
end
|
|
)");
|
|
|
|
LUAU_REQUIRE_NO_ERRORS(result);
|
|
CHECK_EQ("string", toString(requireTypeAtPosition({10, 24})));
|
|
CHECK_EQ("string", toString(requireTypeAtPosition({11, 24})));
|
|
}
|
|
|
|
TEST_CASE_FIXTURE(BuiltinsFixture, "if_not_x_break_if_not_y_break")
|
|
{
|
|
ScopedFastFlag sff{FFlag::LuauTinyControlFlowAnalysis, true};
|
|
|
|
CheckResult result = check(R"(
|
|
local function f(x: {{value: string?}}, y: {{value: string?}})
|
|
for i, recordX in x do
|
|
local recordY = y[i]
|
|
if not recordX.value then
|
|
break
|
|
end
|
|
|
|
if not recordY.value then
|
|
break
|
|
end
|
|
|
|
local foo = recordX.value
|
|
local bar = recordY.value
|
|
end
|
|
end
|
|
)");
|
|
|
|
LUAU_REQUIRE_NO_ERRORS(result);
|
|
CHECK_EQ("string", toString(requireTypeAtPosition({12, 38})));
|
|
CHECK_EQ("string", toString(requireTypeAtPosition({13, 38})));
|
|
}
|
|
|
|
TEST_CASE_FIXTURE(BuiltinsFixture, "if_not_x_continue_if_not_y_continue")
|
|
{
|
|
ScopedFastFlag sff{FFlag::LuauTinyControlFlowAnalysis, true};
|
|
|
|
CheckResult result = check(R"(
|
|
local function f(x: {{value: string?}}, y: {{value: string?}})
|
|
for i, recordX in x do
|
|
local recordY = y[i]
|
|
if not recordX.value then
|
|
continue
|
|
end
|
|
|
|
if not recordY.value then
|
|
continue
|
|
end
|
|
|
|
local foo = recordX.value
|
|
local bar = recordY.value
|
|
end
|
|
end
|
|
)");
|
|
|
|
LUAU_REQUIRE_NO_ERRORS(result);
|
|
CHECK_EQ("string", toString(requireTypeAtPosition({12, 38})));
|
|
CHECK_EQ("string", toString(requireTypeAtPosition({13, 38})));
|
|
}
|
|
|
|
TEST_CASE_FIXTURE(BuiltinsFixture, "if_not_x_continue_if_not_y_throw")
|
|
{
|
|
ScopedFastFlag sff{FFlag::LuauTinyControlFlowAnalysis, true};
|
|
|
|
CheckResult result = check(R"(
|
|
local function f(x: {{value: string?}}, y: {{value: string?}})
|
|
for i, recordX in x do
|
|
local recordY = y[i]
|
|
if not recordX.value then
|
|
continue
|
|
end
|
|
|
|
if not recordY.value then
|
|
error("Y value not defined")
|
|
end
|
|
|
|
local foo = recordX.value
|
|
local bar = recordY.value
|
|
end
|
|
end
|
|
)");
|
|
|
|
LUAU_REQUIRE_NO_ERRORS(result);
|
|
CHECK_EQ("string", toString(requireTypeAtPosition({12, 38})));
|
|
CHECK_EQ("string", toString(requireTypeAtPosition({13, 38})));
|
|
}
|
|
|
|
TEST_CASE_FIXTURE(BuiltinsFixture, "if_not_x_break_if_not_y_continue")
|
|
{
|
|
ScopedFastFlag sff{FFlag::LuauTinyControlFlowAnalysis, true};
|
|
|
|
CheckResult result = check(R"(
|
|
local function f(x: {{value: string?}}, y: {{value: string?}})
|
|
for i, recordX in x do
|
|
local recordY = y[i]
|
|
if not recordX.value then
|
|
break
|
|
end
|
|
|
|
if not recordY.value then
|
|
continue
|
|
end
|
|
|
|
local foo = recordX.value
|
|
local bar = recordY.value
|
|
end
|
|
end
|
|
)");
|
|
|
|
LUAU_REQUIRE_NO_ERRORS(result);
|
|
CHECK_EQ("string", toString(requireTypeAtPosition({12, 38})));
|
|
CHECK_EQ("string", toString(requireTypeAtPosition({13, 38})));
|
|
}
|
|
|
|
TEST_CASE_FIXTURE(BuiltinsFixture, "type_alias_does_not_leak_out")
|
|
{
|
|
ScopedFastFlag sff{FFlag::LuauTinyControlFlowAnalysis, true};
|
|
|
|
CheckResult result = check(R"(
|
|
local function f(x: string?)
|
|
if typeof(x) == "string" then
|
|
return
|
|
else
|
|
type Foo = number
|
|
end
|
|
|
|
local foo: Foo = x
|
|
end
|
|
)");
|
|
|
|
LUAU_REQUIRE_ERROR_COUNT(1, result);
|
|
|
|
CHECK_EQ("Unknown type 'Foo'", toString(result.errors[0]));
|
|
|
|
CHECK_EQ("nil", toString(requireTypeAtPosition({8, 29})));
|
|
}
|
|
|
|
TEST_CASE_FIXTURE(BuiltinsFixture, "type_alias_does_not_leak_out_breaking")
|
|
{
|
|
ScopedFastFlag sff{FFlag::LuauTinyControlFlowAnalysis, true};
|
|
|
|
CheckResult result = check(R"(
|
|
local function f(x: {{value: string?}})
|
|
for _, record in x do
|
|
if typeof(record.value) == "string" then
|
|
break
|
|
else
|
|
type Foo = number
|
|
end
|
|
|
|
local foo: Foo = record.value
|
|
end
|
|
end
|
|
)");
|
|
|
|
LUAU_REQUIRE_ERROR_COUNT(1, result);
|
|
|
|
CHECK_EQ("Unknown type 'Foo'", toString(result.errors[0]));
|
|
|
|
CHECK_EQ("nil", toString(requireTypeAtPosition({9, 43})));
|
|
}
|
|
|
|
TEST_CASE_FIXTURE(BuiltinsFixture, "type_alias_does_not_leak_out_continuing")
|
|
{
|
|
ScopedFastFlag sff{FFlag::LuauTinyControlFlowAnalysis, true};
|
|
|
|
CheckResult result = check(R"(
|
|
local function f(x: {{value: string?}})
|
|
for _, record in x do
|
|
if typeof(record.value) == "string" then
|
|
continue
|
|
else
|
|
type Foo = number
|
|
end
|
|
|
|
local foo: Foo = record.value
|
|
end
|
|
end
|
|
)");
|
|
|
|
LUAU_REQUIRE_ERROR_COUNT(1, result);
|
|
|
|
CHECK_EQ("Unknown type 'Foo'", toString(result.errors[0]));
|
|
|
|
CHECK_EQ("nil", toString(requireTypeAtPosition({9, 43})));
|
|
}
|
|
|
|
TEST_CASE_FIXTURE(BuiltinsFixture, "prototyping_and_visiting_alias_has_the_same_scope")
|
|
{
|
|
ScopedFastFlag sff{FFlag::LuauTinyControlFlowAnalysis, true};
|
|
|
|
// In CG, we walk the block to prototype aliases. We then visit the block in-order, which will resolve the prototype to a real type.
|
|
// That second walk assumes that the name occurs in the same `Scope` that the prototype walk had. If we arbitrarily change scope midway
|
|
// through, we'd invoke UB.
|
|
CheckResult result = check(R"(
|
|
local function f(x: string?)
|
|
type Foo = number
|
|
|
|
if typeof(x) == "string" then
|
|
return
|
|
end
|
|
|
|
local foo: Foo = x
|
|
end
|
|
)");
|
|
|
|
LUAU_REQUIRE_ERROR_COUNT(1, result);
|
|
|
|
CHECK_EQ("Type 'nil' could not be converted into 'number'", toString(result.errors[0]));
|
|
|
|
CHECK_EQ("nil", toString(requireTypeAtPosition({8, 29})));
|
|
}
|
|
|
|
TEST_CASE_FIXTURE(BuiltinsFixture, "prototyping_and_visiting_alias_has_the_same_scope_breaking")
|
|
{
|
|
ScopedFastFlag sff{FFlag::LuauTinyControlFlowAnalysis, true};
|
|
|
|
CheckResult result = check(R"(
|
|
local function f(x: {{value: string?}})
|
|
for _, record in x do
|
|
type Foo = number
|
|
|
|
if typeof(record.value) == "string" then
|
|
break
|
|
end
|
|
|
|
local foo: Foo = record.value
|
|
end
|
|
end
|
|
)");
|
|
|
|
LUAU_REQUIRE_ERROR_COUNT(1, result);
|
|
|
|
CHECK_EQ("Type 'nil' could not be converted into 'number'", toString(result.errors[0]));
|
|
|
|
CHECK_EQ("nil", toString(requireTypeAtPosition({9, 43})));
|
|
}
|
|
|
|
TEST_CASE_FIXTURE(BuiltinsFixture, "prototyping_and_visiting_alias_has_the_same_scope_continuing")
|
|
{
|
|
ScopedFastFlag sff{FFlag::LuauTinyControlFlowAnalysis, true};
|
|
|
|
CheckResult result = check(R"(
|
|
local function f(x: {{value: string?}})
|
|
for _, record in x do
|
|
type Foo = number
|
|
|
|
if typeof(record.value) == "string" then
|
|
continue
|
|
end
|
|
|
|
local foo: Foo = record.value
|
|
end
|
|
end
|
|
)");
|
|
|
|
LUAU_REQUIRE_ERROR_COUNT(1, result);
|
|
|
|
CHECK_EQ("Type 'nil' could not be converted into 'number'", toString(result.errors[0]));
|
|
|
|
CHECK_EQ("nil", toString(requireTypeAtPosition({9, 43})));
|
|
}
|
|
|
|
TEST_CASE_FIXTURE(BuiltinsFixture, "tagged_unions")
|
|
{
|
|
ScopedFastFlag sff{FFlag::LuauTinyControlFlowAnalysis, true};
|
|
|
|
CheckResult result = check(R"(
|
|
type Ok<T> = { tag: "ok", value: T }
|
|
type Err<E> = { tag: "err", error: E }
|
|
type Result<T, E> = Ok<T> | Err<E>
|
|
|
|
local function map<T, U, E>(result: Result<T, E>, f: (T) -> U): Result<U, E>
|
|
if result.tag == "ok" then
|
|
local tag = result.tag
|
|
local val = result.value
|
|
|
|
return { tag = "ok", value = f(result.value) }
|
|
end
|
|
|
|
local tag = result.tag
|
|
local err = result.error
|
|
|
|
return result
|
|
end
|
|
)");
|
|
|
|
LUAU_REQUIRE_NO_ERRORS(result);
|
|
|
|
CHECK_EQ("\"ok\"", toString(requireTypeAtPosition({7, 35})));
|
|
CHECK_EQ("T", toString(requireTypeAtPosition({8, 35})));
|
|
|
|
CHECK_EQ("\"err\"", toString(requireTypeAtPosition({13, 31})));
|
|
CHECK_EQ("E", toString(requireTypeAtPosition({14, 31})));
|
|
|
|
CHECK_EQ("Err<E>", toString(requireTypeAtPosition({16, 19})));
|
|
}
|
|
|
|
TEST_CASE_FIXTURE(BuiltinsFixture, "tagged_unions_breaking")
|
|
{
|
|
ScopedFastFlag sff{FFlag::LuauTinyControlFlowAnalysis, true};
|
|
|
|
CheckResult result = check(R"(
|
|
type Ok<T> = { tag: "ok", value: T }
|
|
type Err<E> = { tag: "err", error: E }
|
|
type Result<T, E> = Ok<T> | Err<E>
|
|
|
|
local function process<T, E>(results: {Result<T, E>})
|
|
for _, result in results do
|
|
if result.tag == "ok" then
|
|
local tag = result.tag
|
|
local val = result.value
|
|
|
|
break
|
|
end
|
|
|
|
local tag = result.tag
|
|
local err = result.error
|
|
end
|
|
end
|
|
)");
|
|
|
|
LUAU_REQUIRE_NO_ERRORS(result);
|
|
|
|
CHECK_EQ("\"ok\"", toString(requireTypeAtPosition({8, 39})));
|
|
CHECK_EQ("T", toString(requireTypeAtPosition({9, 39})));
|
|
|
|
CHECK_EQ("\"err\"", toString(requireTypeAtPosition({14, 35})));
|
|
CHECK_EQ("E", toString(requireTypeAtPosition({15, 35})));
|
|
}
|
|
|
|
TEST_CASE_FIXTURE(BuiltinsFixture, "tagged_unions_continuing")
|
|
{
|
|
ScopedFastFlag sff{FFlag::LuauTinyControlFlowAnalysis, true};
|
|
|
|
CheckResult result = check(R"(
|
|
type Ok<T> = { tag: "ok", value: T }
|
|
type Err<E> = { tag: "err", error: E }
|
|
type Result<T, E> = Ok<T> | Err<E>
|
|
|
|
local function process<T, E>(results: {Result<T, E>})
|
|
for _, result in results do
|
|
if result.tag == "ok" then
|
|
local tag = result.tag
|
|
local val = result.value
|
|
|
|
continue
|
|
end
|
|
|
|
local tag = result.tag
|
|
local err = result.error
|
|
end
|
|
end
|
|
)");
|
|
|
|
LUAU_REQUIRE_NO_ERRORS(result);
|
|
|
|
CHECK_EQ("\"ok\"", toString(requireTypeAtPosition({8, 39})));
|
|
CHECK_EQ("T", toString(requireTypeAtPosition({9, 39})));
|
|
|
|
CHECK_EQ("\"err\"", toString(requireTypeAtPosition({14, 35})));
|
|
CHECK_EQ("E", toString(requireTypeAtPosition({15, 35})));
|
|
}
|
|
|
|
TEST_CASE_FIXTURE(BuiltinsFixture, "do_assert_x")
|
|
{
|
|
ScopedFastFlag sff{FFlag::LuauTinyControlFlowAnalysis, true};
|
|
|
|
CheckResult result = check(R"(
|
|
local function f(x: string?)
|
|
do
|
|
assert(x)
|
|
end
|
|
|
|
local foo = x
|
|
end
|
|
)");
|
|
|
|
LUAU_REQUIRE_NO_ERRORS(result);
|
|
|
|
CHECK_EQ("string", toString(requireTypeAtPosition({6, 24})));
|
|
}
|
|
|
|
TEST_SUITE_END();
|