mirrors/luau
1
0
Fork 0
mirror of https://github.com/luau-lang/luau.git synced 2024-11-15 14:25:44 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

revert cmake file + update makefile

Browse Source
This commit is contained in:
Vighnesh 2024-10-11 16:57:52 -07:00
parent 5d74685798
commit 837bba31e4
2 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
CMakeLists.txt
View File

@ -114,8 +114,6 @@ else()
list(APPEND LUAU_OPTIONS -Wall) # All warnings list(APPEND LUAU_OPTIONS -Wall) # All warnings
list(APPEND LUAU_OPTIONS -Wimplicit-fallthrough) list(APPEND LUAU_OPTIONS -Wimplicit-fallthrough)
list(APPEND LUAU_OPTIONS -Wsign-compare) # This looks to be included in -Wall for GCC but not clang list(APPEND LUAU_OPTIONS -Wsign-compare) # This looks to be included in -Wall for GCC but not clang
list(APPEND LUAU_OPTIONS -Wno-maybe-uninitialized)
endif() endif()
if (CMAKE_CXX_COMPILER_ID STREQUAL "MSVC") if (CMAKE_CXX_COMPILER_ID STREQUAL "MSVC")
@ -126,8 +124,6 @@ if (CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
# Some gcc versions treat var in `if (type var = val)` as unused # Some gcc versions treat var in `if (type var = val)` as unused
# Some gcc versions treat variables used in constexpr if blocks as unused # Some gcc versions treat variables used in constexpr if blocks as unused
list(APPEND LUAU_OPTIONS -Wno-unused) list(APPEND LUAU_OPTIONS -Wno-unused)
# GCC has some bugs where we optional<string> is treated as uninitialized if it is on a structg
endif() endif()
# Enabled in CI; we should be warning free on our main compiler versions but don't guarantee being warning free everywhere # Enabled in CI; we should be warning free on our main compiler versions but don't guarantee being warning free everywhere

2
Makefile
View File

@ -82,8 +82,10 @@ LDFLAGS=
# some gcc versions treat var in `if (type var = val)` as unused # some gcc versions treat var in `if (type var = val)` as unused
# some gcc versions treat variables used in constexpr if blocks as unused # some gcc versions treat variables used in constexpr if blocks as unused
# some gcc versions warn maybe uninitalized on optional<std::string> members on structs
ifeq ($(findstring g++,$(shell $(CXX) --version)),g++) ifeq ($(findstring g++,$(shell $(CXX) --version)),g++)
CXXFLAGS+=-Wno-unused CXXFLAGS+=-Wno-unused
CXXFLAGS+=-Wno-maybe-uninitialized
endif endif
# enabled in CI; we should be warning free on our main compiler versions but don't guarantee being warning free everywhere # enabled in CI; we should be warning free on our main compiler versions but don't guarantee being warning free everywhere