2022-10-22 01:54:01 +08:00
|
|
|
// This file is part of the Luau programming language and is licensed under MIT License; see LICENSE.txt for details
|
2022-12-03 02:09:59 +08:00
|
|
|
#include "Luau/DataFlowGraph.h"
|
2022-10-22 01:54:01 +08:00
|
|
|
#include "Luau/Error.h"
|
|
|
|
#include "Luau/Parser.h"
|
|
|
|
|
|
|
|
#include "AstQueryDsl.h"
|
|
|
|
#include "ScopedFlags.h"
|
|
|
|
|
|
|
|
#include "doctest.h"
|
|
|
|
|
|
|
|
using namespace Luau;
|
|
|
|
|
2023-03-04 04:21:14 +08:00
|
|
|
struct DataFlowGraphFixture
|
2022-10-22 01:54:01 +08:00
|
|
|
{
|
|
|
|
// Only needed to fix the operator== reflexivity of an empty Symbol.
|
|
|
|
ScopedFastFlag dcr{"DebugLuauDeferredConstraintResolution", true};
|
|
|
|
|
|
|
|
InternalErrorReporter handle;
|
|
|
|
|
|
|
|
Allocator allocator;
|
|
|
|
AstNameTable names{allocator};
|
|
|
|
AstStatBlock* module;
|
|
|
|
|
|
|
|
std::optional<DataFlowGraph> graph;
|
|
|
|
|
|
|
|
void dfg(const std::string& code)
|
|
|
|
{
|
|
|
|
ParseResult parseResult = Parser::parse(code.c_str(), code.size(), names, allocator);
|
|
|
|
if (!parseResult.errors.empty())
|
|
|
|
throw ParseErrors(std::move(parseResult.errors));
|
|
|
|
module = parseResult.root;
|
|
|
|
graph = DataFlowGraphBuilder::build(module, NotNull{&handle});
|
|
|
|
}
|
|
|
|
|
|
|
|
template<typename T, int N>
|
2023-10-21 09:10:30 +08:00
|
|
|
DefId getDef(const std::vector<Nth>& nths = {nth<T>(N)})
|
2022-10-22 01:54:01 +08:00
|
|
|
{
|
|
|
|
T* node = query<T, N>(module, nths);
|
|
|
|
REQUIRE(node);
|
2023-10-21 09:10:30 +08:00
|
|
|
return graph->getDef(node);
|
2022-10-22 01:54:01 +08:00
|
|
|
}
|
|
|
|
};
|
|
|
|
|
|
|
|
TEST_SUITE_BEGIN("DataFlowGraphBuilder");
|
|
|
|
|
|
|
|
TEST_CASE_FIXTURE(DataFlowGraphFixture, "define_locals_in_local_stat")
|
|
|
|
{
|
|
|
|
dfg(R"(
|
|
|
|
local x = 5
|
|
|
|
local y = x
|
|
|
|
)");
|
|
|
|
|
2023-10-21 09:10:30 +08:00
|
|
|
(void)getDef<AstExprLocal, 1>();
|
2022-10-22 01:54:01 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
TEST_CASE_FIXTURE(DataFlowGraphFixture, "define_parameters_in_functions")
|
|
|
|
{
|
|
|
|
dfg(R"(
|
|
|
|
local function f(x)
|
|
|
|
local y = x
|
|
|
|
end
|
|
|
|
)");
|
|
|
|
|
2023-10-21 09:10:30 +08:00
|
|
|
(void)getDef<AstExprLocal, 1>();
|
2022-10-22 01:54:01 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
TEST_CASE_FIXTURE(DataFlowGraphFixture, "find_aliases")
|
|
|
|
{
|
|
|
|
dfg(R"(
|
|
|
|
local x = 5
|
|
|
|
local y = x
|
|
|
|
local z = y
|
|
|
|
)");
|
|
|
|
|
2023-10-21 09:10:30 +08:00
|
|
|
DefId x = getDef<AstExprLocal, 1>();
|
|
|
|
DefId y = getDef<AstExprLocal, 2>();
|
2023-03-04 04:21:14 +08:00
|
|
|
REQUIRE(x != y);
|
2022-10-22 01:54:01 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
TEST_CASE_FIXTURE(DataFlowGraphFixture, "independent_locals")
|
|
|
|
{
|
|
|
|
dfg(R"(
|
|
|
|
local x = 5
|
|
|
|
local y = 5
|
|
|
|
|
|
|
|
local a = x
|
|
|
|
local b = y
|
|
|
|
)");
|
|
|
|
|
2023-10-21 09:10:30 +08:00
|
|
|
DefId x = getDef<AstExprLocal, 1>();
|
|
|
|
DefId y = getDef<AstExprLocal, 2>();
|
2022-10-22 01:54:01 +08:00
|
|
|
REQUIRE(x != y);
|
|
|
|
}
|
|
|
|
|
2023-11-11 05:10:07 +08:00
|
|
|
TEST_CASE_FIXTURE(DataFlowGraphFixture, "phi")
|
|
|
|
{
|
|
|
|
dfg(R"(
|
|
|
|
local x
|
|
|
|
|
|
|
|
if a then
|
|
|
|
x = true
|
|
|
|
end
|
|
|
|
|
|
|
|
local y = x
|
|
|
|
)");
|
|
|
|
|
|
|
|
DefId y = getDef<AstExprLocal, 2>();
|
|
|
|
|
|
|
|
const Phi* phi = get<Phi>(y);
|
|
|
|
CHECK(phi);
|
|
|
|
}
|
|
|
|
|
|
|
|
TEST_CASE_FIXTURE(DataFlowGraphFixture, "mutate_local_not_owned_by_while")
|
|
|
|
{
|
|
|
|
dfg(R"(
|
|
|
|
local x
|
|
|
|
|
|
|
|
while cond() do
|
|
|
|
x = true
|
|
|
|
end
|
|
|
|
|
|
|
|
local y = x
|
|
|
|
)");
|
|
|
|
|
|
|
|
DefId x0 = graph->getDef(query<AstStatLocal>(module)->vars.data[0]);
|
|
|
|
DefId x1 = getDef<AstExprLocal, 1>(); // x = true
|
|
|
|
DefId x2 = getDef<AstExprLocal, 2>(); // local y = x
|
|
|
|
|
|
|
|
CHECK(x0 == x1);
|
|
|
|
CHECK(x1 == x2);
|
|
|
|
}
|
|
|
|
|
|
|
|
TEST_CASE_FIXTURE(DataFlowGraphFixture, "mutate_local_owned_by_while")
|
|
|
|
{
|
|
|
|
dfg(R"(
|
|
|
|
while cond() do
|
|
|
|
local x
|
|
|
|
x = true
|
|
|
|
x = 5
|
|
|
|
end
|
|
|
|
)");
|
|
|
|
|
|
|
|
DefId x0 = graph->getDef(query<AstStatLocal>(module)->vars.data[0]);
|
|
|
|
DefId x1 = getDef<AstExprLocal, 1>(); // x = true
|
|
|
|
DefId x2 = getDef<AstExprLocal, 2>(); // x = 5
|
|
|
|
|
|
|
|
CHECK(x0 != x1);
|
|
|
|
CHECK(x1 != x2);
|
|
|
|
}
|
|
|
|
|
|
|
|
TEST_CASE_FIXTURE(DataFlowGraphFixture, "mutate_local_not_owned_by_repeat")
|
|
|
|
{
|
|
|
|
dfg(R"(
|
|
|
|
local x
|
|
|
|
|
|
|
|
repeat
|
|
|
|
x = true
|
|
|
|
until cond()
|
|
|
|
|
|
|
|
local y = x
|
|
|
|
)");
|
|
|
|
|
|
|
|
DefId x0 = graph->getDef(query<AstStatLocal>(module)->vars.data[0]);
|
|
|
|
DefId x1 = getDef<AstExprLocal, 1>(); // x = true
|
|
|
|
DefId x2 = getDef<AstExprLocal, 2>(); // local y = x
|
|
|
|
|
|
|
|
CHECK(x0 == x1);
|
|
|
|
CHECK(x1 == x2);
|
|
|
|
}
|
|
|
|
|
|
|
|
TEST_CASE_FIXTURE(DataFlowGraphFixture, "mutate_local_owned_by_repeat")
|
|
|
|
{
|
|
|
|
dfg(R"(
|
|
|
|
repeat
|
|
|
|
local x
|
|
|
|
x = true
|
|
|
|
x = 5
|
|
|
|
until cond()
|
|
|
|
)");
|
|
|
|
|
|
|
|
DefId x0 = graph->getDef(query<AstStatLocal>(module)->vars.data[0]);
|
|
|
|
DefId x1 = getDef<AstExprLocal, 1>(); // x = true
|
|
|
|
DefId x2 = getDef<AstExprLocal, 2>(); // x = 5
|
|
|
|
|
|
|
|
CHECK(x0 != x1);
|
|
|
|
CHECK(x1 != x2);
|
|
|
|
}
|
|
|
|
|
|
|
|
TEST_CASE_FIXTURE(DataFlowGraphFixture, "mutate_local_not_owned_by_for")
|
|
|
|
{
|
|
|
|
dfg(R"(
|
|
|
|
local x
|
|
|
|
|
|
|
|
for i = 0, 5 do
|
|
|
|
x = true
|
|
|
|
end
|
|
|
|
|
|
|
|
local y = x
|
|
|
|
)");
|
|
|
|
|
|
|
|
DefId x0 = graph->getDef(query<AstStatLocal>(module)->vars.data[0]);
|
|
|
|
DefId x1 = getDef<AstExprLocal, 1>(); // x = true
|
|
|
|
DefId x2 = getDef<AstExprLocal, 2>(); // local y = x
|
|
|
|
|
|
|
|
CHECK(x0 == x1);
|
|
|
|
CHECK(x1 == x2);
|
|
|
|
}
|
|
|
|
|
|
|
|
TEST_CASE_FIXTURE(DataFlowGraphFixture, "mutate_local_owned_by_for")
|
|
|
|
{
|
|
|
|
dfg(R"(
|
|
|
|
for i = 0, 5 do
|
|
|
|
local x
|
|
|
|
x = true
|
|
|
|
x = 5
|
|
|
|
end
|
|
|
|
)");
|
|
|
|
|
|
|
|
DefId x0 = graph->getDef(query<AstStatLocal>(module)->vars.data[0]);
|
|
|
|
DefId x1 = getDef<AstExprLocal, 1>(); // x = true
|
|
|
|
DefId x2 = getDef<AstExprLocal, 2>(); // x = 5
|
|
|
|
|
|
|
|
CHECK(x0 != x1);
|
|
|
|
CHECK(x1 != x2);
|
|
|
|
}
|
|
|
|
|
|
|
|
TEST_CASE_FIXTURE(DataFlowGraphFixture, "mutate_local_not_owned_by_for_in")
|
|
|
|
{
|
|
|
|
dfg(R"(
|
|
|
|
local x
|
|
|
|
|
|
|
|
for i, v in t do
|
|
|
|
x = true
|
|
|
|
end
|
|
|
|
|
|
|
|
local y = x
|
|
|
|
)");
|
|
|
|
|
|
|
|
DefId x0 = graph->getDef(query<AstStatLocal>(module)->vars.data[0]);
|
|
|
|
DefId x1 = getDef<AstExprLocal, 1>(); // x = true
|
|
|
|
DefId x2 = getDef<AstExprLocal, 2>(); // local y = x
|
|
|
|
|
|
|
|
CHECK(x0 == x1);
|
|
|
|
CHECK(x1 == x2);
|
|
|
|
}
|
|
|
|
|
|
|
|
TEST_CASE_FIXTURE(DataFlowGraphFixture, "mutate_local_owned_by_for_in")
|
|
|
|
{
|
|
|
|
dfg(R"(
|
|
|
|
for i, v in t do
|
|
|
|
local x
|
|
|
|
x = true
|
|
|
|
x = 5
|
|
|
|
end
|
|
|
|
)");
|
|
|
|
|
|
|
|
DefId x0 = graph->getDef(query<AstStatLocal>(module)->vars.data[0]);
|
|
|
|
DefId x1 = getDef<AstExprLocal, 1>(); // x = true
|
|
|
|
DefId x2 = getDef<AstExprLocal, 2>(); // x = 5
|
|
|
|
|
|
|
|
CHECK(x0 != x1);
|
|
|
|
CHECK(x1 != x2);
|
|
|
|
}
|
|
|
|
|
|
|
|
TEST_CASE_FIXTURE(DataFlowGraphFixture, "mutate_preexisting_property_not_owned_by_while")
|
|
|
|
{
|
|
|
|
dfg(R"(
|
|
|
|
local t = {}
|
|
|
|
t.x = 5
|
|
|
|
|
|
|
|
while cond() do
|
|
|
|
t.x = true
|
|
|
|
end
|
|
|
|
|
|
|
|
local y = t.x
|
|
|
|
)");
|
|
|
|
|
|
|
|
DefId x1 = getDef<AstExprIndexName, 1>(); // t.x = 5
|
|
|
|
DefId x2 = getDef<AstExprIndexName, 2>(); // t.x = true
|
|
|
|
DefId x3 = getDef<AstExprIndexName, 3>(); // local y = t.x
|
|
|
|
|
|
|
|
CHECK(x1 == x2);
|
|
|
|
CHECK(x2 == x3);
|
|
|
|
}
|
|
|
|
|
|
|
|
TEST_CASE_FIXTURE(DataFlowGraphFixture, "mutate_non_preexisting_property_not_owned_by_while")
|
|
|
|
{
|
|
|
|
dfg(R"(
|
|
|
|
local t = {}
|
|
|
|
|
|
|
|
while cond() do
|
|
|
|
t.x = true
|
|
|
|
end
|
|
|
|
|
|
|
|
local y = t.x
|
|
|
|
)");
|
|
|
|
|
|
|
|
DefId x1 = getDef<AstExprIndexName, 1>(); // t.x = true
|
|
|
|
DefId x2 = getDef<AstExprIndexName, 2>(); // local y = t.x
|
|
|
|
|
|
|
|
CHECK(x1 == x2);
|
|
|
|
}
|
|
|
|
|
|
|
|
TEST_CASE_FIXTURE(DataFlowGraphFixture, "mutate_property_of_table_owned_by_while")
|
|
|
|
{
|
|
|
|
dfg(R"(
|
|
|
|
while cond() do
|
|
|
|
local t = {}
|
|
|
|
t.x = true
|
|
|
|
t.x = 5
|
|
|
|
end
|
|
|
|
)");
|
|
|
|
|
|
|
|
DefId x1 = getDef<AstExprIndexName, 1>(); // t.x = true
|
|
|
|
DefId x2 = getDef<AstExprIndexName, 2>(); // t.x = 5
|
|
|
|
|
|
|
|
CHECK(x1 != x2);
|
|
|
|
}
|
|
|
|
|
2022-10-22 01:54:01 +08:00
|
|
|
TEST_SUITE_END();
|