From f4eb2331e9b01b84c8233dc10c2f798b9f25574e Mon Sep 17 00:00:00 2001 From: Syarif Fakhri Date: Mon, 21 Aug 2023 13:49:04 +0800 Subject: [PATCH] Fix crash in auto hide tab - Crash is caused by dragging an autohide tab out when it is an icon only. - The crash can actually happen with non icon only tabs, but is masked by the orientation check. - Soln: Check if auto hide container exists first on mouse finish dragging event. --- src/AutoHideTab.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/AutoHideTab.cpp b/src/AutoHideTab.cpp index 089fddf..f20fb11 100644 --- a/src/AutoHideTab.cpp +++ b/src/AutoHideTab.cpp @@ -478,7 +478,7 @@ void CAutoHideTab::mouseReleaseEvent(QMouseEvent* ev) case DraggingFloatingWidget: ev->accept(); d->FloatingWidget->finishDragging(); - if (d->DockWidget->isAutoHide() && d->DragStartOrientation != orientation()) + if (d->DockWidget->autoHideDockContainer() && d->DragStartOrientation != orientation()) { d->DockWidget->autoHideDockContainer()->resetToInitialDockWidgetSize(); }