mirrors/Qt-Advanced-Docking-System
1
0
Fork 0
mirror of https://github.com/githubuser0xFFFF/Qt-Advanced-Docking-System.git synced 2025-04-01 02:42:39 +08:00
Code

call CDockWidget::closeDockWidgetInternal when close attempt and CustomCloseHandling (#438)

Browse Source 
Co-authored-by: bjb-work <N/A>
This commit is contained in:
bjb-work 2022-07-15 08:47:20 -04:00 committed by GitHub
parent 75d58b3ea3
commit df74686287
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/DockAreaWidget.cpp
View File

@ -538,7 +538,7 @@ void CDockAreaWidget::onTabCloseRequested(int Index)
{ {
ADS_PRINT("CDockAreaWidget::onTabCloseRequested " << Index); ADS_PRINT("CDockAreaWidget::onTabCloseRequested " << Index);
auto* DockWidget = dockWidget(Index); auto* DockWidget = dockWidget(Index);
if (DockWidget->features().testFlag(CDockWidget::DockWidgetDeleteOnClose)) if (DockWidget->features().testFlag(CDockWidget::DockWidgetDeleteOnClose) || DockWidget->features().testFlag(CDockWidget::CustomCloseHandling))
{ {
DockWidget->closeDockWidgetInternal(); DockWidget->closeDockWidgetInternal();
} }
@ -956,9 +956,12 @@ QAbstractButton* CDockAreaWidget::titleBarButton(TitleBarButton which) const
void CDockAreaWidget::closeArea() void CDockAreaWidget::closeArea()
{ {
// If there is only one single dock widget and this widget has the // If there is only one single dock widget and this widget has the
// DeleteOnClose feature, then we delete the dock widget now // DeleteOnClose feature or CustomCloseHandling, then we delete the dock widget now;
// in the case of CustomCloseHandling, the CDockWidget class will emit its
// closeRequested signal and not actually delete unless the signal is handled in a way that deletes it
auto OpenDockWidgets = openedDockWidgets(); auto OpenDockWidgets = openedDockWidgets();
if (OpenDockWidgets.count() == 1 && OpenDockWidgets[0]->features().testFlag(CDockWidget::DockWidgetDeleteOnClose)) if (OpenDockWidgets.count() == 1 &&
(OpenDockWidgets[0]->features().testFlag(CDockWidget::DockWidgetDeleteOnClose) || OpenDockWidgets[0]->features().testFlag(CDockWidget::CustomCloseHandling)))
{ {
OpenDockWidgets[0]->closeDockWidgetInternal(); OpenDockWidgets[0]->closeDockWidgetInternal();
} }
@ -966,7 +969,8 @@ void CDockAreaWidget::closeArea()
{ {
for (auto DockWidget : openedDockWidgets()) for (auto DockWidget : openedDockWidgets())
{ {
if (DockWidget->features().testFlag(CDockWidget::DockWidgetDeleteOnClose) && DockWidget->features().testFlag(CDockWidget::DockWidgetForceCloseWithArea)) if ((DockWidget->features().testFlag(CDockWidget::DockWidgetDeleteOnClose) && DockWidget->features().testFlag(CDockWidget::DockWidgetForceCloseWithArea)) ||
DockWidget->features().testFlag(CDockWidget::CustomCloseHandling))
DockWidget->closeDockWidgetInternal(); DockWidget->closeDockWidgetInternal();
else else
DockWidget->toggleView(false); DockWidget->toggleView(false);

2
src/FloatingDockContainer.cpp
View File

@ -809,7 +809,7 @@ void CFloatingDockContainer::closeEvent(QCloseEvent *event)
for (auto DockWidget : d->DockContainer->openedDockWidgets()) for (auto DockWidget : d->DockContainer->openedDockWidgets())
{ {
if (DockWidget->features().testFlag(CDockWidget::DockWidgetDeleteOnClose)) if (DockWidget->features().testFlag(CDockWidget::DockWidgetDeleteOnClose) || DockWidget->features().testFlag(CDockWidget::CustomCloseHandling))
{ {
DockWidget->closeDockWidgetInternal(); DockWidget->closeDockWidgetInternal();
} }