mirrors/Qt-Advanced-Docking-System
1
0
Fork 0
mirror of https://github.com/githubuser0xFFFF/Qt-Advanced-Docking-System.git synced 2025-04-01 02:42:39 +08:00
Code

Fix crash that can happen on loading certain configurations

Browse Source 
Prior we were adding dock widgets without removing them from the old
dock area. This can cause the old dock areas current index to become
invalid as the old dock area still thinks it has an equivalent amount of dock widgets.
Attempting to setCurrentIndex on these areas would then cause a crash as it's out of bounds!
This commit is contained in:
Syarif Fakhri 2022-10-31 12:25:09 +08:00
parent a012426f9b
commit d56281e860
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/DockContainerWidget.cpp
View File

@ -1189,6 +1189,12 @@ bool DockContainerWidgetPrivate::restoreDockArea(CDockingStateReader& s,
continue;
}
const auto oldDockArea = DockWidget->dockAreaWidget();
if (oldDockArea)
{
oldDockArea->removeDockWidget(DockWidget);
}
ADS_PRINT("Dock Widget found - parent " << DockWidget->parent());
// We hide the DockArea here to prevent the short display (the flashing)
// of the dock areas during application startup