From 8b436e850d45480fecdbbad6ec6dabdb47bb6302 Mon Sep 17 00:00:00 2001 From: Ahmad Syarifuddin Date: Fri, 23 Jun 2023 15:15:24 +0800 Subject: [PATCH] Bug fix sidebar state during restore (#526) * fix side bar state being incorrect during restore * isVisible is invalid during restore state * Make visibleTabCount function consistent with hasVisibleTabs. Add a bit of documentation. --------- Co-authored-by: Syarif Fakhri --- src/AutoHideSideBar.cpp | 6 +++--- src/AutoHideSideBar.h | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/AutoHideSideBar.cpp b/src/AutoHideSideBar.cpp index f427ca3..cae494d 100644 --- a/src/AutoHideSideBar.cpp +++ b/src/AutoHideSideBar.cpp @@ -279,7 +279,7 @@ bool CAutoHideSideBar::eventFilter(QObject *watched, QEvent *event) show(); break; - case QEvent::Hide: + case QEvent::HideToParent: if (!hasVisibleTabs()) { hide(); @@ -321,7 +321,7 @@ int CAutoHideSideBar::visibleTabCount() const int count = 0; for (auto i = 0; i < tabCount(); i++) { - if (tabAt(i)->isVisible()) + if (tabAt(i)->isVisibleTo(parentWidget())) { count++; } @@ -336,7 +336,7 @@ bool CAutoHideSideBar::hasVisibleTabs() const { for (auto i = 0; i < tabCount(); i++) { - if (tabAt(i)->isVisible()) + if (tabAt(i)->isVisibleTo(parentWidget())) { return true; } diff --git a/src/AutoHideSideBar.h b/src/AutoHideSideBar.h index 20a9e6a..1b0cab5 100644 --- a/src/AutoHideSideBar.h +++ b/src/AutoHideSideBar.h @@ -135,14 +135,14 @@ public: int tabCount() const; /** - * Returns the number of visible tabs + * Returns the number of visible tabs to its parent widget. */ int visibleTabCount() const; /** - * Returns true, if the sidebar contains visible tabs. + * Returns true, if the sidebar contains visible tabs to its parent widget. * The function returns as soon as it finds the first visible tab. - * That means, if you just want to find out if theee are visible tabs + * That means, if you just want to find out if there are visible tabs * then this function is quicker than visibleTabCount() */ bool hasVisibleTabs() const;