mirrors/Qt-Advanced-Docking-System
1
0
Fork 0
mirror of https://github.com/githubuser0xFFFF/Qt-Advanced-Docking-System.git synced 2025-01-24 05:22:06 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix Undefined Behavior in LastAddedAreaCache (#211)

Browse Source
This commit is contained in:
Hannes Schulze 2020-06-28 21:07:17 +02:00 committed by GitHub
parent da20405a6a
commit 0225563b46
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/DockContainerWidget.cpp
View File

@ -1319,9 +1319,9 @@ void CDockContainerWidget::removeDockArea(CDockAreaWidget* area)
internal::hideEmptyParentSplitters(Splitter); internal::hideEmptyParentSplitters(Splitter);
// Remove this area from cached areas // Remove this area from cached areas
const auto& cache = d->LastAddedAreaCache; auto p = std::find(std::begin(d->LastAddedAreaCache), std::end(d->LastAddedAreaCache), area);
if (auto p = std::find(cache, cache+sizeof(cache)/sizeof(cache[0]), area)) { if (p != std::end(d->LastAddedAreaCache)) {
d->LastAddedAreaCache[std::distance(cache, p)] = nullptr; *p = nullptr;
} }
// If splitter has more than 1 widgets, we are finished and can leave // If splitter has more than 1 widgets, we are finished and can leave